Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 51324 invoked from network); 28 Aug 2006 13:54:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 28 Aug 2006 13:54:44 -0000 Received: (qmail 13365 invoked by uid 500); 28 Aug 2006 13:54:42 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 13334 invoked by uid 500); 28 Aug 2006 13:54:42 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 13322 invoked by uid 99); 28 Aug 2006 13:54:41 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Aug 2006 06:54:41 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of foamdino@gmail.com designates 64.233.184.230 as permitted sender) Received: from [64.233.184.230] (HELO wr-out-0506.google.com) (64.233.184.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Aug 2006 06:54:40 -0700 Received: by wr-out-0506.google.com with SMTP id i5so340631wra for ; Mon, 28 Aug 2006 06:54:19 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:mime-version:in-reply-to:references:content-type:message-id:content-transfer-encoding:from:subject:date:to:x-mailer; b=JUp+IowhMllCCdlVwyvdNGfDORU249NEDfBf/BFK/zcIJzPo3ihZ5ByaEg/43wA+OUA+rt7UKhSQplXKxqhi/w4ydgzXyjvardWM1XqAYiNcnCvVJnEnYrb88VJHK5hpgGN60IlZws15LHVhiEA5lLQuF6v54u4cem/taOJhj6o= Received: by 10.90.116.6 with SMTP id o6mr946659agc; Mon, 28 Aug 2006 06:54:19 -0700 (PDT) Received: from ?192.168.1.33? ( [58.186.78.37]) by mx.gmail.com with ESMTP id 15sm2553468nzn.2006.08.28.06.54.15; Mon, 28 Aug 2006 06:54:19 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v752.2) In-Reply-To: References: <20060828075219.D59391A981A@eris.apache.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <80358A6A-B271-4E44-BFC5-9853CEECBC44@gmail.com> Content-Transfer-Encoding: 7bit From: Kev Jackson Subject: Re: svn commit: r437589 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/condition/AntVersion.java Date: Mon, 28 Aug 2006 21:02:42 +0700 To: "Ant Developers List" X-Mailer: Apple Mail (2.752.2) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 28 Aug 2006, at 19:09, Antoine Levy-Lambert wrote: > Hi, > > I am not very fond of this versionString.indexOf("Ant version") > +17); either. > A regular expression looking for a string of digits and dots would > be what we are looking for ? Unfortunately regexps aren't available in Java 1.2[1], do you have another suggestion for avoiding the brittle indexOf method? I'm happy to work on this to fix it, or if you are still unhappy, pull it from the release - your call. Thanks Kev [1] http://marc.theaimsgroup.com/?l=ant-dev&m=114861730527898&w=2 -- "Government is begotten of aggression, by aggression" - Herbert Spencer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org