ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Reilly" <peter.kitt.rei...@gmail.com>
Subject Re: svn commit: r439014 - in /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/condition: ConditionBase.java antlib.xml
Date Thu, 31 Aug 2006 22:11:54 GMT
On 8/31/06, mbenson@apache.org <mbenson@apache.org> wrote:
>
> Author: mbenson
> Date: Thu Aug 31 12:04:12 2006
> New Revision: 439014
>
> URL: http://svn.apache.org/viewvc?rev=439014&view=rev
> Log:
> Auto-discover built-in conditions added >= 1.7 from the accompanying
> antlib so we can stop adding junk setters to ConditionBase.
> ...



I do not like this change.

1) mixing add(Type) and createDynamicElement() is normally not
    good.
2) this is a strange way to use antlibs (nice but strange).

3) most of the types can be put in o.a.t.a.types.default.properties without
   problems (isX or Xcondition).

Peter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message