ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <>
Subject Re: Use of reflection in DirectoryScanner to remove duplicated code
Date Wed, 23 Aug 2006 04:38:34 GMT
On Wed, 23 Aug 2006, Kev Jackson <> wrote:

> I want to run this by people here to see what people think of this.
> Basically DirectoryScanner has some duplicated code [
> accountForIncludedFile, accountForIncludedDir ], I think I have a
> refactored processIncluded method that can replace the duplication,
> but it relies on using Reflection to get access to the classes
> fields and then does the work [1].

Please run some tests on really large directory trees,
DirectoryScanner is probably the class with the biggest impact on
perceived Ant performance.  We shouldn't do anything that makes it
significantly slower.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message