ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: svn commit: r439014 - in /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/condition: ConditionBase.java antlib.xml
Date Thu, 31 Aug 2006 22:31:38 GMT
--- Peter Reilly <peter.kitt.reilly@gmail.com> wrote:

> On 8/31/06, mbenson@apache.org <mbenson@apache.org>
> wrote:
> >
> > Author: mbenson
> > Date: Thu Aug 31 12:04:12 2006
> > New Revision: 439014
> >
> > URL:
> http://svn.apache.org/viewvc?rev=439014&view=rev
> > Log:
> > Auto-discover built-in conditions added >= 1.7
> from the accompanying
> > antlib so we can stop adding junk setters to
> ConditionBase.
> > ...
> 
> I do not like this change.

:(

> 
> 1) mixing add(Type) and createDynamicElement() is
> normally not
>     good.

IH handles it; add(Type) gets precedence, as I think
it should... is there really a "normally" where
Dynamic(Element|Attribute)(NS)? are concerned; i.e.
are they really used widely enough to say what is
"normal" use?

> 2) this is a strange way to use antlibs (nice but
> strange).

IMHO it's not really any stranger than ComponentHelper
knowing that no ns usually means ant-core.

> 
> 3) most of the types can be put in
> o.a.t.a.types.default.properties without
>    problems (isX or Xcondition).
> 

This is probably true, but there needs to be consensus
here because someone commented
oata.types/defaults.properties with the idea of adding
conditions only to the antlib in question.  I just
think we can do better than adding a setter every time
we ship a new condition.

-Matt

> Peter
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message