ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: svn commit: r438953 - /ant/core/trunk/src/main/org/apache/tools/ant/Project.java
Date Thu, 31 Aug 2006 16:15:55 GMT
--- Dominique Devienne <ddevienne@gmail.com> wrote:

> On 8/31/06, mbenson@apache.org <mbenson@apache.org>
> wrote:
> > Strike lying comment.
> > -     * @param value The value of the reference.
> Must not be <code>null</code>.
> > +     * @param value The value of the reference.
> 
> How about enforcing the comment in fact? Binding
> null values to refs
> is bad, and will only show up later in the build,
> making it difficult
> to troubleshoot, no?
> 
> So why not throw an NPE or IllegalArgEx for null
> values? --DD

No preference here.  :)  But you make sense.

-Matt

> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message