ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40207] - hashCode() in Target breaks XmlLogger (and CruiseControl)
Date Thu, 31 Aug 2006 16:12:31 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40207>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40207





------- Additional Comments From peterreilly@apache.org  2006-08-31 16:12 -------
The following buildfile also shows the problem:
<project basedir="." default="call-me" name="1">
    
    <target name="1">
	<antcall target="2"/>
    </target>

    <target name="2" unless="ONCE">
        <property name="ONCE" value="SET"/>
        <antcall target="1"/>
    </target>

    <target name="call-me">
        <antcall target="1" />
    </target>
</project>

The Target.java code adding the hash and equals method was
changed with the comment "flip tests as the IDE was complaining
that we werent handing null tokens properly" (stevel). I
do not think that they are needed, and as the above
example shows two target with same name and build file may
exist at the same time - so the equals and hash should include
a test for the project instance - but it would be better to
just remove the methods!




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message