ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40152] - rmic: Ant 1.7 adds -vcompat when building iiop stubs
Date Wed, 02 Aug 2006 18:16:19 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40152>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40152





------- Additional Comments From stevel@apache.org  2006-08-02 18:16 -------
I that added this. I did it because the switch to java1.5 was breaking things,
as suddenly, silently, rmic wasnt creating backwards compatible bits. You dont
find out that you've stopped creating compatible stubs when 

Now, regarding the patch

<         cmd.createArgument().setValue(stubOption);
---
>         if (stubVersion == null && !attributes.getIiop())
>            cmd.createArgument().setValue(stubOption);

Um, what happens if stubVersion!=null? Surely we'd actualy want the stub version
people asked for to be set.

I will commit a patch that works, if it comes with
 -unit tests that fail before they are applied (antunit ones are good)
 -rmic tests that set a stub version and which don't fail when the patch goes in.

-steve

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message