ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40140] - Let task/types receive unexpanded attribute(s)
Date Mon, 31 Jul 2006 05:55:28 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40140>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40140





------- Additional Comments From efanomars@yahoo.com  2006-07-31 05:55 -------
Created an attachment (id=18663)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18663&action=view)
Patch to pass unexpanded attributes to tasks

** Sources **
IntrospectionHelper.java:
 - added method unexpandedAttributes(Object bean)
   returning the list of unexpanded attribute names

RuntimeConfigurable.java:
 - changed maybeConfigure() to call replaceProperties()
   only if attribute not in the list (or the list is null) 

ProjectHelper.java:
 - same as RuntimeConfigurable.java
  I also patched this file's configure() method even though it is
  deprecated. My guess is that if there isn't a throw exception in it,
  it might be called. Since I was there I also changed the way 
  replaceProperties is called (AFAIK it is needlessly cloning the 
  project's properties, but maybe there is a reason for that).

** Tests **
CustomTasksTest.java:
  - just a quick superficial test to see whether it works.

** Note **
Modified and patched against latest 1.70alpha.

Stefano Marsili

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message