ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40093] - ant.PropertyHelper reference not passed to called build
Date Fri, 28 Jul 2006 13:15:49 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40093>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40093


efanomars@yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18640|0                           |1
        is obsolete|                            |
  Attachment #18641|0                           |1
        is obsolete|                            |




------- Additional Comments From efanomars@yahoo.com  2006-07-28 13:15 -------
Created an attachment (id=18659)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18659&action=view)
Patches of sources, tests and docu, plus new files

PropertyHelper patches.
 
Why (the problem): 
  even though it is possible for a custom task to install a 
  new property helper as a hook or even as the main property helper, 
  at present there is no way to pass the helper to subbuilds. 
  The additional data in the PropertyHelper subclass and the hooks 
  are not inherited. 
Proposed solution:
  this patch extends the PropertyHelper interface to install
  and clone PropertyHelper instances in a way suitable to Ant.

** Sources **
PropertyHelper.java:
 - installPropertyHelper(project, newHelper) 
      to install a custom PropertyHelper into a project 
 - clonePropertyHelper(fromProject, newProject, inheritAll)
      to clone a PropertyHelper to a new project and optionally
      copy hooks' properties to their clones
 - areYouOverridableBy(newHelper) method that let's the main 
      property helper decide whether it wants to give up control 
      of the build's property handling to a new helper.

Ant.java, CallTarget.java, SubAnt.java: 
 - new "inheritph" attribute telling whether the property helper
   and its hooks should be cloned to the new project

** Tests **
PropertyHelperTest.java:
 - created new test case, testing installation of property helpers
   and hooks into a project

AntTest.java, CallTargetTest.java:
 - extended to test cloning of property helper and its hooks

** Docu **
Ant.html, AntCall.html, SubAnt.html:
 - added "inheritph" attribute with a small comment

** Note **
Modified and patched against latest 1.70alpha.
The proposed changes should be backward compatible.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message