ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruce Atherton <br...@callenish.com>
Subject Re: [vote] 'undeprecate project.resolveFile() [was Re: svn commit: r414442 - in /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs: AbstractJarSignerTask.java ExecTask.java Javac.java Javadoc.java TempFile.java Touch.java XSLTProcess.java]
Date Sun, 18 Jun 2006 20:09:46 GMT
I'm +1 for undeprecating.

You make a good case that Project is doing too much, but I don't think 
that deprecating before a good solution is arrived at is a good idea. 
And a solution that breaks DRY and adds more code dependencies on the 
Singleton Antipattern is not a good solution IMHO.

Martijn Kruithof wrote:
> I'd like to throw in a -0 in that case (not too bothered either)
>
> (as of here what I just wrote before:)
> I think Project has become too much of a "God" class. It has almost 
> 100 public methods, more than 80 are not deprecated. I understand it 
> is convenient to have a proxy towards every utility in Project, still 
> I 'd say Project is having too much responsibilities and it is good to 
> remove the responsibility of a utility class from the Project class.
>
> Martijn
>
> Kev Jackson schreef:
>
>>
>> On 16 Jun 2006, at 07:00, Antoine Levy-Lambert wrote:
>>
>>>
>>> -------- Original-Nachricht --------
>>> Datum: Thu, 15 Jun 2006 15:14:57 -0500
>>> Von: Dominique Devienne <ddevienne@gmail.com>
>>> An: Ant Developers List <dev@ant.apache.org>
>>> Betreff: Re: Re: svn commit: r414442 - in /ant/core/trunk/src/main/ 
>>> org/apache/tools/ant/taskdefs: AbstractJarSignerTask.java  
>>> ExecTask.java Javac.java Javadoc.java TempFile.java Touch.java  
>>> XSLTProcess.java
>>>
>>>> This has been deprecated by jkf in commit 396012, @since 1.7  
>>>> apparently.
>>>>
>>> this is true
>>>
>>>> So it can be undeprecated, and Kev's changes can be removed ;-)
>>>
>>
>> So quick vote to 'undeprecate' project.resolveFile()
>>
>> my +0 (I'm not too bothered, but if the rest vote to undeprecate,  
>> then I'll undertake the work to put everything back to the way it 
>> was  before I started messing with things)
>>
>> Kev
>>
>> -- 
>> "All governments are in equal measure good and evil.  The best ideal  
>> is anarchy." - Leo Tolstoy
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message