ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antoine Levy-Lambert" <anto...@gmx.de>
Subject [VOTE] change junitreport to delegate to XSLTTask
Date Fri, 16 Jun 2006 14:54:26 GMT
Hi,

I plan to apply the patches contained in the bug report submitted by Ivan Ivanov, titled :


Modify <junitreport> task to support nested parameters that will be passed to the underlying
XSLT transformation

http://issues.apache.org/bugzilla/show_bug.cgi?id=39708

This patch renders the classes XalanExecutor, Xalan1Executor, Xalan2Executor in the package
org.apache.tools.ant.taskdefs.optional.junit useless.

This by itself does not break API BC. The advantage is that it will allow JunitReport to use
all the features of XSLTask, starting with the possibility of passing parameters to the XSLT
transfortmation.

However, I have thought that maybe someone might object to the change.


So I have 2 questions :

1) do you agree that I submit the patch containing in the bug report 39708, rendering the
XalanExecutor, Xalan1Executor, Xalan2Executor classes useless and never called by our APIs.

Yes []
No []

2) if you answered yes to the first question, do you think that we should

[a] leave the 3 classes XalanExecutor, Xalan1Executor, Xalan2Executor unchanged

[b] mark them as deprecated

[c] remove them physically, as they are not needed any more

Let me start with +1 for the first question.
For the second, my preference would be for the option c which is completely clear, but somewhat
breaks BC.

Regards,

Antoine





---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message