ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: svn commit: r405524 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/Execute.java main/org/apache/tools/ant/taskdefs/rmic/ForkingSunRmic.java testcases/org/apache/tools/ant/taskdefs/ExecuteWatchdogTest.java
Date Thu, 11 May 2006 03:33:53 GMT
On Wed, 10 May 2006, Steve Loughran <stevel@apache.org> wrote:
> Stefan Bodewig wrote:
>> On Tue, 09 May 2006, <stevel@apache.org> wrote:
>>
>>> As well as simplifying a common operation, it is a foundation for
>>> instance specific logic to decide if an execute failed, which
>>> could be of use in VMS land.
>> You better check with your contacts in the OpenVMS group for some
>> of your changes.  The tasks executing Java VMs (this includes tasks
>> running rmic or javac) explicitly checked for a 0 exit code since
>> we've been told the Java VM wouldn't be playing be OpenVMS rules
>> and return 0 on success.
>>
> 
> I havent actually done any vms-ready work, just wrapped up the
> process of getting the return code then checking for a failure into
> a method that is part of the Execute() instance.

No, you also changed ForkingJavaRmic to use isFailure() instead of the
exitCode == 0 check that was in it before.  If rmic returns 0 on
success on OpenVMS, you've just broken the task.

> Personally, I'm not 100% sure that you can have a zero-change switch
> to getting something like jboss to build on OpenVMs,

I agree.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message