Return-Path: 
 <dev-return-71862-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 8201 invoked from network); 24 Apr 2006 02:31:02 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 24 Apr 2006 02:31:02 -0000
Received: (qmail 6751 invoked by uid 500); 24 Apr 2006 02:31:01 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 6709 invoked by uid 500); 24 Apr 2006 02:31:00 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 6698 invoked by uid 99); 24 Apr 2006 02:31:00 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Apr 2006 19:31:00 -0700
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: domain of antoine@gmx.de designates
 213.165.64.20 as permitted sender)
Received: from [213.165.64.20] (HELO mail.gmx.net) (213.165.64.20)
    by apache.org (qpsmtpd/0.29) with SMTP; Sun, 23 Apr 2006 19:31:00 -0700
Received: (qmail invoked by alias); 24 Apr 2006 02:30:38 -0000
Received: from 207-237-61-80.c3-0.nyr-ubr2.nyr.ny.cable.rcn.com (EHLO
 [192.168.11.3]) [207.237.61.80]
  by mail.gmx.net (mp035) with SMTP; 24 Apr 2006 04:30:38 +0200
X-Authenticated: #22961642
Message-ID: <444C3834.7070003@gmx.de>
Date: Sun, 23 Apr 2006 22:30:12 -0400
From: Antoine Levy-Lambert <antoine@gmx.de>
User-Agent: Thunderbird 1.5.0.2 (Windows/20060308)
MIME-Version: 1.0
To: Ant Developers List <dev@ant.apache.org>
Subject: Re: [patch] NioFileUtils, Java6FileUtils, FileUtilsAdapter + factory,
 build.xml (was Re: AW: Adding a methof to StringUtils)
References: <20060421141538.69446.qmail@web30910.mail.mud.yahoo.com>
 <444C2658.4020501@it.fts-vn.com>
In-Reply-To: <444C2658.4020501@it.fts-vn.com>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Kev Jackson wrote:
>
> I'm coming round to think that Martijn's approach would be the least
> disruptive to the code base - simply as the delegate approach wouldn't
> mean recoding all tasks to use an interface instead of an
> implementation.  This reduces the effort a lot and would make it less
> likely that errors would creep in.  Definitely my +1 for the delegate
> approach, +0 for the interfaces and factory approach (ie if for some
> reason we can't do the delagate approach, the interfaces should be
> reconsidered)
>
Sounds good.

When you plugin the nio, it would be good if you test the following :

- building under 1.4 or 1.5, running under 1.2

- I am also concerned about users building their own ant distribution
under Java 1.2, then running it under 1.4 and 1.5, and then complaining
that org.apache.tools.ant.types.jdk14 cannot be found.

Similarly, I wonder what happens for a user who would

           1) build ant under JDK 1.2,
            2) run ant under JDK 1.4,

and attempt to use the RegexpFactory, for instance through the
<replaceregexp/> task ?.

The RegexpFactory does not check whether
org.apache.tools.ant.util.regexp.Jdk14RegexpRegexp is present,
only whether java.util.regex.Matcher is present.

Actually, I was wondering whether we are not already forbidding - de
facto and silently - this type of use cases.



Regards,
Antoine

Antoine
> Thanks
> Kev
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org