Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 73287 invoked from network); 24 Apr 2006 01:11:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 24 Apr 2006 01:11:56 -0000 Received: (qmail 43155 invoked by uid 500); 24 Apr 2006 01:11:55 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 43093 invoked by uid 500); 24 Apr 2006 01:11:55 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 43081 invoked by uid 99); 24 Apr 2006 01:11:54 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Apr 2006 18:11:54 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [210.245.32.200] (HELO mail.fts-vn.com) (210.245.32.200) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Apr 2006 18:11:54 -0700 Received: from sg0104.fts-vn.com ([172.16.1.32]) by mail.fts-vn.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1FXpbt-0001i6-3z for dev@ant.apache.org; Mon, 24 Apr 2006 08:11:29 +0700 Message-ID: <444C2658.4020501@it.fts-vn.com> Date: Mon, 24 Apr 2006 08:14:00 +0700 From: Kev Jackson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ant Developers List Subject: Re: [patch] NioFileUtils, Java6FileUtils, FileUtilsAdapter + factory, build.xml (was Re: AW: Adding a methof to StringUtils) References: <20060421141538.69446.qmail@web30910.mail.mud.yahoo.com> In-Reply-To: <20060421141538.69446.qmail@web30910.mail.mud.yahoo.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.8 {--} X-Spam-Report: Spam detection software, running on the system "mail.fts-vn.com", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >FileUtils to select (Martijn's approach is >ridiculously insane enough to have captured my fancy >;) ), it must also take into account whether the >desired classes are available, falling back to the >basic impl. otherwise. > > I'm coming round to think that Martijn's approach would be the least disruptive to the code base - simply as the delegate approach wouldn't mean recoding all tasks to use an interface instead of an implementation. This reduces the effort a lot and would make it less likely that errors would creep in. Definitely my +1 for the delegate approach, +0 for the interfaces and factory approach (ie if for some reason we can't do the delagate approach, the interfaces should be reconsidered) [...] Content analysis details: (-2.8 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.8 ALL_TRUSTED Did not pass through any untrusted hosts 0.0 AWL AWL: From: address is in the auto white-list X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N >FileUtils to select (Martijn's approach is >ridiculously insane enough to have captured my fancy >;) ), it must also take into account whether the >desired classes are available, falling back to the >basic impl. otherwise. > > I'm coming round to think that Martijn's approach would be the least disruptive to the code base - simply as the delegate approach wouldn't mean recoding all tasks to use an interface instead of an implementation. This reduces the effort a lot and would make it less likely that errors would creep in. Definitely my +1 for the delegate approach, +0 for the interfaces and factory approach (ie if for some reason we can't do the delagate approach, the interfaces should be reconsidered) Thanks Kev --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org