Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 60482 invoked from network); 15 Apr 2006 14:44:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 15 Apr 2006 14:44:10 -0000 Received: (qmail 48748 invoked by uid 500); 15 Apr 2006 14:44:09 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 48671 invoked by uid 500); 15 Apr 2006 14:44:08 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 48658 invoked by uid 99); 15 Apr 2006 14:44:07 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Apr 2006 07:44:07 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of ddevienne@gmail.com designates 64.233.162.193 as permitted sender) Received: from [64.233.162.193] (HELO nz-out-0102.google.com) (64.233.162.193) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 15 Apr 2006 07:44:07 -0700 Received: by nz-out-0102.google.com with SMTP id q3so221861nzb for ; Sat, 15 Apr 2006 07:43:46 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Hbz1TVFAdNoEqk4DhsnZsl0g2pxZJEVKewFuAyVZcFpfqgTuIE8REQgRPapoBtM+iJqjPnhJntBx5JrQvz3mgzf8qThZmB5FFb05SpIVXt6WmcRmvCJ/WvkKnRf51N/Zdi/BawrQMUiMvWoj/vumBL9AA1SXJGoqpWP0cVYOmTQ= Received: by 10.64.96.6 with SMTP id t6mr606617qbb; Sat, 15 Apr 2006 07:43:46 -0700 (PDT) Received: by 10.64.112.20 with HTTP; Sat, 15 Apr 2006 07:43:46 -0700 (PDT) Message-ID: <255d8d690604150743g7d031da6vbafe3d7d98af8edf@mail.gmail.com> Date: Sat, 15 Apr 2006 09:43:46 -0500 From: "Dominique Devienne" To: "Ant Developers List" Subject: Re: svn commit: r393996 - /ant/core/trunk/src/main/org/apache/tools/ant/launch/Launcher.java In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20060414012405.3561.qmail@minotaur.apache.org> <443F47A2.70601@apache.org> <443F9945.909@gmx.de> <443FBE1E.1040801@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N > ok, I think the consensus is that I shouldn't have committed this > change ie -1 to this change from while -> for. I'm also a proponent of using for loops rather than while loops for Iterators. I picked up the idiom reading "The Java Programming Language", and I like the added scope it provides, which is useful since I tend to use just i (or j / k for nested loops) for the iterator variable. In this particular instance, it doesn't help much though, as the var has an explicit name, the method is short, and the for loop itself is broken down on 2 lines. OTOH, I don't like Antoine's for loop ;-) I haven't tried, but I wouldn't have thought it compiled either ;-))) -DD --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org