ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antoine Levy-Lambert <anto...@gmx.de>
Subject Re: [patch] NioFileUtils, Java6FileUtils, FileUtilsAdapter + factory, build.xml (was Re: AW: Adding a methof to StringUtils)
Date Mon, 24 Apr 2006 02:30:12 GMT
Kev Jackson wrote:
>
> I'm coming round to think that Martijn's approach would be the least
> disruptive to the code base - simply as the delegate approach wouldn't
> mean recoding all tasks to use an interface instead of an
> implementation.  This reduces the effort a lot and would make it less
> likely that errors would creep in.  Definitely my +1 for the delegate
> approach, +0 for the interfaces and factory approach (ie if for some
> reason we can't do the delagate approach, the interfaces should be
> reconsidered)
>
Sounds good.

When you plugin the nio, it would be good if you test the following :

- building under 1.4 or 1.5, running under 1.2

- I am also concerned about users building their own ant distribution
under Java 1.2, then running it under 1.4 and 1.5, and then complaining
that org.apache.tools.ant.types.jdk14 cannot be found.

Similarly, I wonder what happens for a user who would

           1) build ant under JDK 1.2,
            2) run ant under JDK 1.4,

and attempt to use the RegexpFactory, for instance through the
<replaceregexp/> task ?.

The RegexpFactory does not check whether
org.apache.tools.ant.util.regexp.Jdk14RegexpRegexp is present,
only whether java.util.regex.Matcher is present.

Actually, I was wondering whether we are not already forbidding - de
facto and silently - this type of use cases.



Regards,
Antoine

Antoine
> Thanks
> Kev
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message