ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 39320] - [PATCH] Simple code cleanups
Date Wed, 26 Apr 2006 20:43:28 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39320>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39320





------- Additional Comments From jkf@apache.org  2006-04-26 20:43 -------
I am applying this patch,

except for the marking public inner classes as static, this would be a non
backward compatible change (existing compiled tasks external to ant would break)
But I am marking another private inner class static

The PathConvert.java has an explicit note about using != instead of ! equals so
I didn't lift that one either.

And finally I didn't apply the chained .append parts, but unchained them instead.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message