ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j..@apache.org
Subject svn commit: r396465 - /ant/core/trunk/src/main/org/apache/tools/ant/types/ArchiveFileSet.java
Date Mon, 24 Apr 2006 07:10:56 GMT
Author: jkf
Date: Mon Apr 24 00:10:54 2006
New Revision: 396465

URL: http://svn.apache.org/viewcvs?rev=396465&view=rev
Log:
Whitespace / contants / javadoc

Modified:
    ant/core/trunk/src/main/org/apache/tools/ant/types/ArchiveFileSet.java

Modified: ant/core/trunk/src/main/org/apache/tools/ant/types/ArchiveFileSet.java
URL: http://svn.apache.org/viewcvs/ant/core/trunk/src/main/org/apache/tools/ant/types/ArchiveFileSet.java?rev=396465&r1=396464&r2=396465&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/types/ArchiveFileSet.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/types/ArchiveFileSet.java Mon Apr 24 00:10:54
2006
@@ -36,6 +36,8 @@
  */
 public abstract class ArchiveFileSet extends FileSet {
 
+    private static final int BASE_OCTAL = 8;
+
     /**
      * Default value for the dirmode attribute.
      *
@@ -158,6 +160,7 @@
 
     /**
      * Get the archive file from which entries will be extracted.
+     * @return the archive in case the archive is a file, null otherwise.
      */
     public File getSrc() {
         if (src instanceof FileResource) {
@@ -165,7 +168,7 @@
         }
         return null;
     }
-    
+
     /**
      * Prepend this prefix to the path for each archive entry.
      * Prevents both prefix and fullpath from being specified
@@ -190,7 +193,7 @@
         }
         return prefix;
     }
-    
+
     /**
      * Set the full pathname of the single entry in this fileset.
      * Prevents both prefix and fullpath from being specified
@@ -215,7 +218,7 @@
         }
         return fullpath;
     }
-    
+
     /**
      * Creates a scanner for this type of archive.
      */
@@ -300,7 +303,7 @@
      * @param octalString a <code>String</code> value
      */
     public void setFileMode(String octalString) {
-        integerSetFileMode(Integer.parseInt(octalString, 8));
+        integerSetFileMode(Integer.parseInt(octalString, BASE_OCTAL));
     }
 
     /**
@@ -348,7 +351,7 @@
      * @param octalString a <code>String</code> value
      */
     public void setDirMode(String octalString) {
-        integerSetDirMode(Integer.parseInt(octalString, 8));
+        integerSetDirMode(Integer.parseInt(octalString, BASE_OCTAL));
     }
 
     /**



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message