ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 39320] - [PATCH] Simple code cleanups
Date Tue, 18 Apr 2006 02:01:08 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39320>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39320





------- Additional Comments From kevin.jackson@it.fts-vn.com  2006-04-18 02:01 -------
(In reply to comment #3)
> Which change appeared to affect logic, Kev?  I apparently didn't catch it...

Sorry, my mistake, 
I thought this affected the logic, but going through it more closely it has no
effect - need some new eyes :)

Index: src/main/org/apache/tools/ant/UnknownElement.java
===================================================================
--- src/main/org/apache/tools/ant/UnknownElement.java	(revision 394071)
+++ src/main/org/apache/tools/ant/UnknownElement.java	(working copy)
@@ -608,6 +608,6 @@
     }
 
     private static boolean equalsString(String a, String b) {
-        return (a == null) ? (a == b) : a.equals(b);
+        return (a == null) ? (null == b) : a.equals(b);
     }
 }




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message