ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 39320] - [PATCH] Simple code cleanups
Date Mon, 17 Apr 2006 02:20:46 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39320>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39320





------- Additional Comments From kevin.jackson@it.fts-vn.com  2006-04-17 02:20 -------
Do you have any tests for this patch?  I think one of teh changes affects
behaviour (logic) rather than simple cleanup.

For the + -> append changes (using StringBuffer), these are trivial and can be
merged in as they only affect the memory consumption of the app (reducing it). 
If you could provide tests I'd be happier with the other changes.

Thanks
Kev

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message