ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 38392] New: - DotNet Antlib (1.6.2 compatible) MSBuild task doesn't properly delimit target and property parameters
Date Wed, 25 Jan 2006 23:02:27 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38392>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38392

           Summary: DotNet Antlib (1.6.2 compatible) MSBuild task doesn't
                    properly delimit target and property parameters
           Product: Ant
           Version: 1.6.5
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: minor
          Priority: P3
         Component: Other
        AssignedTo: dev@ant.apache.org
        ReportedBy: bwatson@dataimage.net


The MSBuild task (DotNet 1.6.2 compatible) fails to properly delimit targets and 
properties when multiple targets or properties are specified.

Example
<msbuild>
        <property name="Prop1" value="abc"/>
        <property name="Prop2" value="xyz"/>
</msbuild>

results in -p:Prop1=abcProp2=xyz.  Note the missing semicolon between the Prop1 
and Prop2 name-value pairs.  Patch follows:

Index: MSBuildTask.java
===================================================================
--- MSBuildTask.java    (revision 372335)
+++ MSBuildTask.java    (working copy)
@@ -64,6 +64,9 @@
                 if (!first) {
                     sb.append(";");
                 }
+                else {
+                    first = false;
+                }
                 sb.append(t.getName());
             }
             return new String[]{sb.toString()};
@@ -83,6 +86,9 @@
                 if (!first) {
                     sb.append(";");
                 }
+                else {
+                    first=false;
+                }
                 sb.append(p.getName()).append("=").append(p.getValue());
             }
             return new String[]{sb.toString()};
~

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message