ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 37795] - [PATCH] Making file sizes optional in DifferentSelector
Date Tue, 06 Dec 2005 21:35:41 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37795>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37795





------- Additional Comments From stevel@apache.org  2005-12-06 22:35 -------
The main reason for allowing you to ignore the contents in a difference test is
because the performance of that is awful on files that actually match. 

Both the source and dest files need parsing and byte-for-byte comparision, which
is slow. Over a network, it is extra slow. 

so by saying ignore file sizes you are cheating, you are saying 'ignore the file
times' -which you ought to do over a network, and 'ignore the file contents'.
you are therefore defining different to be 'two files of different sizes are
different; if they are the same size, we assume they are the same'

once you ignore file sizes you define different as "two files are different only
if one exists". Which is what the <present> selector already did at the time of
writing. 

We dont need an extra feature that another selector does, because it only adds
complexity, bugreps and test cases. 

At the same time, I dont want you to feel disappointed that we have rejected
your work. There was nothing wrong with the code, and you submitted a patch
exactly as we like it. It was just we had a different solution to the problem
somewhere else. Please dont be dissuaded from submitting more bugreps or
patches, and hassling us to get the patches committed :)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message