Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 49194 invoked from network); 1 Nov 2005 21:54:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Nov 2005 21:54:25 -0000 Received: (qmail 48267 invoked by uid 500); 1 Nov 2005 21:54:23 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 48193 invoked by uid 500); 1 Nov 2005 21:54:23 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 48171 invoked by uid 99); 1 Nov 2005 21:54:22 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Nov 2005 13:54:22 -0800 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [68.142.200.161] (HELO web30908.mail.mud.yahoo.com) (68.142.200.161) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 01 Nov 2005 13:54:17 -0800 Received: (qmail 80141 invoked by uid 60001); 1 Nov 2005 21:53:59 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:Received:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=fSh4juVpGdzjFfHiCNEdVIXePxxuwREVkB8dHfMb/WoYkNCMutzNQEtEEjsAwLNNWxvIEoRTAb4FraTP8qQlO2JBg42noAm/d7+FqvjWk4b/KGBwJOk7H/EWIz0ljz13/lzlnvA2x6R/OLx61WI5P7HW/ibSYLizC9j35H4uQbA= ; Message-ID: <20051101215359.80139.qmail@web30908.mail.mud.yahoo.com> Received: from [66.10.233.130] by web30908.mail.mud.yahoo.com via HTTP; Tue, 01 Nov 2005 13:53:59 PST Date: Tue, 1 Nov 2005 13:53:59 -0800 (PST) From: Matt Benson Subject: Re: XmlProperty, AntUnit, questions To: Ant Developers List In-Reply-To: <4367DB1A.3010205@grafidog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N I'm not Stefan, and I want his reactions on certain points, but FWIW: --- Dale Anson wrote: > Several questions at once, they sort of led one to > another... > > First question(s) -- > I wanted to use the XmlProperty task. I have a > custom task that > provides some xml as output in a property. The > XmlProperty task only > reads from a file, so I needed to write my property > value to a file so I > could read it back in with XmlProperty, which seems > like an unnecessary > step. It's a pretty simple modification to > XmlProperty to allow it to > accept xml in a property rather than a file. Is > there any interest in > this modification? Or would this question be better > placed on the user list? I haven't seen you around the lists for awhile until recently, Dale... The ongoing resource collection work in Ant HEAD seeks to address this exact type of situation in a generic way. The "right" fix, therefore, IMO is to modify XmlProperty to accept its input from a resource. Since in the case of this task a single resource is wanted as input it doesn't seem right to accept a whole resource collection, although I suppose that is one option. This leads me to an issue I've been waiting to present for some time: does Ant >= 1.7 need a mechanism for specifying a specifically typed resource from a String, and accompanying modifications to IntrospectionHelper to... help with the introspection? :) e.g.: file:foo url:http://ant.apache.org/index.html property:foo etc. ? Hopefully replies to this email will fragment into separate threads, but now I will address the antunit issue. :) > > Second question -- > I went ahead and made the modifications to > XmlProperty to read from a > property, and thought to submit a patch. A while > back, I wrote some > unit test tasks and use them a lot for testing > custom tasks. I noticed these when I was going through the split task. ;) These are > a lot easier and faster to write than the junit > tests. I just can't > seem to get motivated to actually write a junit test > for an Ant task, I know the feeling! > and I recalled that Stefan had mentioned that he'd > wrote some unit > testing tasks also. A quick google found them in > the Ant Sandbox area > as AntUnit. Would it be acceptable to submit a > patch to a core task > that included a unit test that uses the AntUnit > library? > I hope Stefan makes it clearer (if he's taken it that far) how we can integrate antunit into Ant's testing to eventually replace junit (my ambitious hope anyway). > And last question, for Stefan -- > Do you want any help with AntUnit? I see you've set > the compatibility > level for Ant 1.7. I commented out one line so I > can run it with Ant 1.6.5. > The only problem I see with that is that I had planned to make antunit also support ResourceCollections... so back to 1.7 if we did that. I suppose we could always retrofit after 1.7 release if we wanted a release compatible with 1.6.5 though. -Matt > Thanks, > > Dale > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > dev-unsubscribe@ant.apache.org > For additional commands, e-mail: > dev-help@ant.apache.org > > __________________________________ Yahoo! FareChase: Search multiple travel sites in one click. http://farechase.yahoo.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org