Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 10490 invoked from network); 27 Oct 2005 16:13:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 27 Oct 2005 16:13:34 -0000 Received: (qmail 95007 invoked by uid 500); 27 Oct 2005 16:13:32 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 94965 invoked by uid 500); 27 Oct 2005 16:13:31 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 94954 invoked by uid 99); 27 Oct 2005 16:13:31 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2005 09:13:31 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of bblinn@gmail.com designates 64.233.184.192 as permitted sender) Received: from [64.233.184.192] (HELO wproxy.gmail.com) (64.233.184.192) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2005 09:13:27 -0700 Received: by wproxy.gmail.com with SMTP id i2so177843wra for ; Thu, 27 Oct 2005 09:13:09 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=VJQFBOhER1HGaccflRADedYqrS2je7GTn7XHR7Cix9Xq8G1c24UEnD4H8axsy1IPG05nw7L2ivzuYNe0x+dWmd7oYEIL2V9X6tR+tEkYG2P6ecuiudNyfVnD2MqPGg+E5/t/YqxUEjPQFm88ZvH9HIS0gnq3qRY3ZrjFY1gvEnE= Received: by 10.54.132.4 with SMTP id f4mr1001091wrd; Thu, 27 Oct 2005 09:13:08 -0700 (PDT) Received: by 10.54.95.9 with HTTP; Thu, 27 Oct 2005 09:13:08 -0700 (PDT) Message-ID: Date: Thu, 27 Oct 2005 12:13:08 -0400 From: Bill Blinn To: dev@ant.apache.org Subject: [Patch] CvsTagDiff throws NullPointerException is cvsRoot is not specified MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N If cvsRoot is not specified when executing the CvsTagDiff target, a NullPointerException is thrown: E:\cygwin\home\matt\build\bill-build-20051022\basin\build.xml:669: The following error occurred while executing this line: E:\cygwin\home\matt\build\bill-build-20051022\basin\client-build2.xml:102: java.lang.NullPointerException at org.apache.tools.ant.ProjectHelper.addLocationToBuildException(P= rojectHelper.java:539) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:384) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:= 275) at org.apache.tools.ant.Task.perform(Task.java:364) at org.apache.tools.ant.Target.execute(Target.java:341) at org.apache.tools.ant.Target.performTasks(Target.java:369) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1= 216) at org.apache.tools.ant.Project.executeTarget(Project.java:1185) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(Defau= ltExecutor.java:40) at org.apache.tools.ant.Project.executeTargets(Project.java:1068) at org.apache.tools.ant.Main.runBuild(Main.java:668) at org.apache.tools.ant.Main.startAnt(Main.java:187) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:246) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:67) Caused by: E:\cygwin\home\matt\build\bill-build-20051022\basin\client-build= 2.xml:102: java.lang.NullPointerException at org.apache.tools.ant.Task.perform(Task.java:373) at org.apache.tools.ant.Target.execute(Target.java:341) at org.apache.tools.ant.Target.performTasks(Target.java:369) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1= 216) at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(S= ingleCheckExecutor.java:37) at org.apache.tools.ant.Project.executeTargets(Project.java:1068) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:382) ... 12 more Caused by: java.lang.NullPointerException at org.apache.tools.ant.util.DOMElementWriter.encode(DOMElementWrit= er.java:207) at org.apache.tools.ant.util.DOMElementWriter.openElement(DOMElemen= tWriter.java:165) at org.apache.tools.ant.taskdefs.cvslib.CvsTagDiff.writeTagDiff(Cvs= TagDiff.java:378) at org.apache.tools.ant.taskdefs.cvslib.CvsTagDiff.execute(CvsTagDi= ff.java:237) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:= 275) at org.apache.tools.ant.Task.perform(Task.java:364) ... 18 more --- Nested Exception --- E:\cygwin\home\matt\build\bill-build-20051022\basin\client-build2.xml:102: java.lang.NullPointerException at org.apache.tools.ant.Task.perform(Task.java:373) at org.apache.tools.ant.Target.execute(Target.java:341) at org.apache.tools.ant.Target.performTasks(Target.java:369) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1= 216) at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(S= ingleCheckExecutor.java:37) at org.apache.tools.ant.Project.executeTargets(Project.java:1068) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:382) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:= 275) at org.apache.tools.ant.Task.perform(Task.java:364) at org.apache.tools.ant.Target.execute(Target.java:341) at org.apache.tools.ant.Target.performTasks(Target.java:369) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1= 216) at org.apache.tools.ant.Project.executeTarget(Project.java:1185) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(Defau= ltExecutor.java:40) at org.apache.tools.ant.Project.executeTargets(Project.java:1068) at org.apache.tools.ant.Main.runBuild(Main.java:668) at org.apache.tools.ant.Main.startAnt(Main.java:187) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:246) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:67) Caused by: java.lang.NullPointerException at org.apache.tools.ant.util.DOMElementWriter.encode(DOMElementWrit= er.java:207) at org.apache.tools.ant.util.DOMElementWriter.openElement(DOMElemen= tWriter.java:165) at org.apache.tools.ant.taskdefs.cvslib.CvsTagDiff.writeTagDiff(Cvs= TagDiff.java:378) at org.apache.tools.ant.taskdefs.cvslib.CvsTagDiff.execute(CvsTagDi= ff.java:237) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:= 275) at org.apache.tools.ant.Task.perform(Task.java:364) ... 18 more --- Nested Exception --- java.lang.NullPointerException at org.apache.tools.ant.util.DOMElementWriter.encode(DOMElementWrit= er.java:207) at org.apache.tools.ant.util.DOMElementWriter.openElement(DOMElemen= tWriter.java:165) at org.apache.tools.ant.taskdefs.cvslib.CvsTagDiff.writeTagDiff(Cvs= TagDiff.java:378) at org.apache.tools.ant.taskdefs.cvslib.CvsTagDiff.execute(CvsTagDi= ff.java:237) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:= 275) at org.apache.tools.ant.Task.perform(Task.java:364) at org.apache.tools.ant.Target.execute(Target.java:341) at org.apache.tools.ant.Target.performTasks(Target.java:369) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1= 216) at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(S= ingleCheckExecutor.java:37) at org.apache.tools.ant.Project.executeTargets(Project.java:1068) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:382) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:= 275) at org.apache.tools.ant.Task.perform(Task.java:364) at org.apache.tools.ant.Target.execute(Target.java:341) at org.apache.tools.ant.Target.performTasks(Target.java:369) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1= 216) at org.apache.tools.ant.Project.executeTarget(Project.java:1185) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(Defau= ltExecutor.java:40) at org.apache.tools.ant.Project.executeTargets(Project.java:1068) at org.apache.tools.ant.Main.runBuild(Main.java:668) at org.apache.tools.ant.Main.startAnt(Main.java:187) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:246) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:67) Total time: 52 seconds This patch should fix the problem: --- apache-ant-1.6.5-src-orig/apache-ant-1.6.5/src/main/org/apache/tools/an= t/taskdefs/cvslib/CvsTagDiff.java 2005-06-02 15:20:00.000000000 -0400 +++ apache-ant-1.6.5-src/apache-ant-1.6.5/src/main/org/apache/tools/ant/tas= kdefs/cvslib/CvsTagDiff.java 2005-10-27 12:01:20.393375000 -0400 @@ -373,7 +373,9 @@ root.setAttribute("endDate", myendDate); } - root.setAttribute("cvsroot", getCvsRoot()); + if(getCvsRoot() !=3D null) { + root.setAttribute("cvsroot", getCvsRoot()); + } root.setAttribute("package", mypackage); DOM_WRITER.openElement(root, writer, 0, "\t"); writer.println(); --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org