ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Weighill-Smith" <phil.weighill-sm...@volantis.com>
Subject RE: <delete> fails if inner fileset directory does not exist.
Date Tue, 25 Oct 2005 12:26:54 GMT
I simply wonder if backwards compatibility is actually necessary here as a missing fileset
base directory causes a build failure and I'd have thought that most builds would not depend
on this sort of scenario. Clearly there could be some (IMHO) strange build scripts that do
rely on this behaviour, but this seems very obscure (correct me if you can think of a common
use case).

	-----Original Message----- 
	From: Jan.Materne@rzf.fin-nrw.de [mailto:Jan.Materne@rzf.fin-nrw.de] 
	Sent: Tue 10/25/2005 09:00 
	To: dev@ant.apache.org 
	Cc: 
	Subject: AW: <delete> fails if inner fileset directory does not exist.
	
	

	With the ability to configure that, we´d get a
	  <fileset failIfDirDoesNotExist="true|false"/> (default=true --> BWC)
	
	Users could override the default with <presetdef>.
	
	
	
	Jan
	
	>-----Ursprüngliche Nachricht-----
	>Von: Phil Weighill-Smith [mailto:phil.weighill-smith@volantis.com]
	>Gesendet: Dienstag, 25. Oktober 2005 09:45
	>An: Ant Developers List
	>Betreff: RE: <delete> fails if inner fileset directory does not exist.
	>
	>My point is more about filesets in general rather than within
	>delete specifically. I'd have thought that since old behaviour
	>is unlikely to be relied on in build files (the implication is
	>that something outside the build script *must* create certain
	>directories otherwise the build fails) changing the behaviour
	>to simply not cause an exception in the directory scanner but
	>rather do a "zero matches" result would suffice.
	>
	>Phil :n.
	>
	>       -----Original Message-----
	>       From: Alexey Solofnenko [mailto:trelony@gmail.com]
	>       Sent: Mon 10/24/2005 22:42
	>       To: Ant Developers List
	>       Cc:
	>       Subject: Re: <delete> fails if inner fileset directory
	>does not exist.
	>      
	>      
	>
	>       I think it would be require something like the following:
	>      
	>          - flag in <fileset>;
	>          - lazy <fileset> initialization, so <delete> can set
	>this flag;
	>          - <delete> should always set this flag on all
	>provided filesets.
	>      
	>       - Alexey.
	>      
	>       On 10/24/05, Phil Weighill-Smith
	><phil.weighill-smith@volantis.com> wrote:
	>       >
	>       > Which has always given me grief. It has always seemed
	>sensible to me that
	>       > a fileset would simply evaluate to no files if the
	>base directory for the
	>       > fileset doesn't exist (and perhaps generate a verbose
	>log mentioning that
	>       > fact) in the same way it does when the pattern(s)
	>doesn't match anything.
	>       >
	>       > Phil :n(
	>       >
	>       > -----Original Message-----
	>       > From: Matt Benson [mailto:gudnabrsam@yahoo.com]
	>       > Sent: Mon 10/24/2005 21:15
	>       > To: Ant Developers List
	>       > Cc:
	>       > Subject: Re: <delete> fails if inner fileset
	>directory does not exist.
	>       >
	>       >
	>       >
	>       > Nothing ever works w/ filesets where the directory
	>       > does not exist...
	>       >
	>       > -Matt
	>       >
	>       > --- "Alexey N. Solofnenko" <A.Solofnenko@mdl.com>
	>       > wrote:
	>       >
	>       > > This does not work:
	>       > >
	>       > > <project name="test" default="all" basedir=".">
	>       > > <target name="all">
	>       > > <delete includeEmptyDirs="true"
	>       > > failonerror="false">
	>       > > <fileset dir="aaa/bbb"/>
	>       > > </delete>
	>       > > </target>
	>       > > </project>
	>       > >
	>       > >
	>       > > - Alexey.
	>       > > --
	>       > >
	>       >
	>---------------------------------------------------------------
	>---------
	>       > > / Alexey N. Solofnenko
	>       > > home: http://trelony.cjb.net/
	>       > > /
	>       > >
	>       > >
	>       >
	>---------------------------------------------------------------------
	>       > > To unsubscribe, e-mail:
	>       > > dev-unsubscribe@ant.apache.org
	>       > > For additional commands, e-mail:
	>       > > dev-help@ant.apache.org
	>       > >
	>       > >
	>       >
	>       >
	>       >
	>       >
	>       > __________________________________
	>       > Yahoo! FareChase: Search multiple travel sites in one click.
	>       > http://farechase.yahoo.com
	>       >
	>       >
	>---------------------------------------------------------------------
	>       > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
	>       > For additional commands, e-mail: dev-help@ant.apache.org
	>       >
	>       >
	>       >
	>       >
	>      
	>      
	>       --
	>       Alexey N. Solofnenko trelony at gmail.com <http://gmail.com>
	>       home: http://trelony.cjb.net/
	>       Pleasant Hill, CA (GMT-8 hours usually)
	>      
	>
	>
	
	---------------------------------------------------------------------
	To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
	For additional commands, e-mail: dev-help@ant.apache.org
	
	

Mime
View raw message