ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 36901] - optional task PropertyFile should retain comments and layout of properties file
Date Mon, 03 Oct 2005 20:06:11 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36901>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36901





------- Additional Comments From hourihanep@yahoo.co.uk  2005-10-03 22:06 -------
I posted the following to dev@ant.apache.org, not realising that
the mailing list normally strip attachments and this may not have
been the best channel to go through. I was advised to create an
enhancement here instead, and submit the material that way.

- - - - - -

Hi folks,

A little while ago I posted that I had code to grant
which would allow the PropertyFile task to retain the
layout of the properties file that it was editing
(mail subject was also "enhancement for PropertyFile,
have a patch").

I was busy for a while, so didn't get around to
posting the changes, but here they are. There are
changes to two files (java source for the task, and
the associated documentation), and a few associated
and test classes.

The changes listed below are contained in the patch
file. The other files are attached individually.

Any feedback or comments welcome. This is my first
submission, so I hope I am doing this right. Feel free
to point it out if I am not.

Changes:
========

src/main/org/apache/tools/ant/taskdefs/optional/PropertyFile.java
	The task now makes use of the
LayoutPreservingProperties (see below). Also, a new
attribute allows the user to select using a regular
java.util.Properties file instead, if they so choose.

docs/manual/OptionalTasks/propertyfile.html
	Documentation changes to follow the task changes.

New files:
==========

src/main/org/apache/tools/ant/util/LayoutPreservingProperties.java
	A subclass of java.util.Properties that preserves the
layout of the input stream(s) from which properties
were loaded (if applicable)
	
src/testcases/org/apache/tools/ant/util/LayoutPreservingPropertiesTest.java
	Unit tests for the new class.

src/etc/testcases/util/simple.properties
src/etc/testcases/util/unusual.properties
	Test data for the unit tests.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message