Return-Path: 
 <dev-return-69161-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 87647 invoked from network); 30 Sep 2005 14:32:18 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 30 Sep 2005 14:32:18 -0000
Received: (qmail 37566 invoked by uid 500); 30 Sep 2005 14:32:17 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 37205 invoked by uid 500); 30 Sep 2005 14:32:16 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 37194 invoked by uid 99); 30 Sep 2005 14:32:16 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Sep 2005 07:32:16 -0700
X-ASF-Spam-Status: No, hits=0.4 required=10.0
	tests=DNS_FROM_RFC_ABUSE
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Received: from [68.142.200.156] (HELO web30903.mail.mud.yahoo.com)
 (68.142.200.156)
    by apache.org (qpsmtpd/0.29) with SMTP; Fri, 30 Sep 2005 07:32:21 -0700
Received: (qmail 63826 invoked by uid 60001); 30 Sep 2005 14:31:54 -0000
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Message-ID:Received:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=GmuQsZS9Sq5KOrrWhjqvL+TnyZEaV7FT9txlV+v0zLAiKuTNsUoOop6PI+2oP4h7JMQxlFUxtsHY6YwcueLkTo/CafU3ppx4+vrPLtMx8a+uNeYtARG43Y694+IG+ivM9kDQ6L4jGguPISDAUNdU26IZsmBhjGjq+cs99ZYLa2Y=
  ;
Message-ID: <20050930143154.63824.qmail@web30903.mail.mud.yahoo.com>
Received: from [65.247.233.205] by web30903.mail.mud.yahoo.com via HTTP;
 Fri, 30 Sep 2005 07:31:54 PDT
Date: Fri, 30 Sep 2005 07:31:54 -0700 (PDT)
From: Matt Benson <gudnabrsam@yahoo.com>
Subject: Re: svn commit: r292420 -
 /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Expand.java
To: Ant Developers List <dev@ant.apache.org>
In-Reply-To: <87br2bjjh5.fsf@www.samaflost.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

--- Stefan Bodewig <bodewig@apache.org> wrote:

> On Thu, 29 Sep 2005, Matt Benson
> <gudnabrsam@yahoo.com> wrote:
> > --- bodewig@apache.org wrote:
> > [SNIP]
> >> Log:
> >> empty collection != no collection - found by Gump
> >> and the jline build
> > 
> > IIRC I had handled similar issues by lazily
> > initializing the internal RC (here Union) and
> testing
> > for null.  :)
> 
> Yes, I understand that now.
> 
> And I understand why you could live with using
> Resources - it throws
> an exception on size() if it doesn't contain any
> resource collections.
> That's one of the main reasons that made me switch
> to Union.

Doesn't matter, we can make empty <resources> valid if
we want to.

> 
> I guess I have to revisit all my changes and switch
> to lazy
> initialization as well.

If what you've already done works, I don't necessarily
see a need to change it.  I just mentioned it.  :)

-Matt
> 
> Stefan
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 



		
__________________________________ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org