Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.co.uk;
  h=Message-ID:Received:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=LxmH0/aIZ1tULbfZ5zTFWvUtjGCGFn4pLF0zg1ktXnUo4zQbBlJ41ni5L0lKTrgcemfETl/LN+LaFtAgaCnCK7pB4ei0jZeEE+IKbsRFTPBeolqeSktw06ydsaUN9FyMcBC4fGDnk2h5jntbYZDykvLLNhI95jd9ymSWT9WKSLg=
  ;
Message-ID: <20050902174915.12030.qmail@web25702.mail.ukl.yahoo.com>
Date: Fri, 2 Sep 2005 18:49:15 +0100 (BST)
From: Phil Hourihane <hourihanep@yahoo.co.uk>
Subject: RE: enhancement for PropertyFile, have a patch
To: Ant Developers List <dev@ant.apache.org>
In-Reply-To: 
 <4C23D8CA64819D44BF3F8134E0CF0E650C3F4D6D@CHAPDMSXMB04.ad.tiaa-cref.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit

Antoine,

I'll certainly have a look at the filterchain stuff
and see how much overlap there is between the work I
did and that. The meterial that I prepared is only in
passing a patch to PropertyFile, the main piece of any
interest is a subclass of Properties which retains the
format of the input stream from which properties were
loaded, and which I thought to put in the public
domain.

Anyway, since you have picqued my interest, I will
look at the filterchain stuff, which I am not
currently familiar with.

PHiL
 

--- "Burgess, Benjamin" <BBurgess@tiaa-cref.org>
wrote:

> +1 - excellent proposal
> 
> -----Original Message-----
> From: Antoine Levy-Lambert [mailto:antoine@gmx.de] 
> Sent: Friday, September 02, 2005 10:03 AM
> To: Ant Developers List
> Subject: Re: enhancement for PropertyFile, have a
> patch
> 
> Hello Phil,
> I wonder whether, instead of patching PropertyFile,
> you should not study
> how the <filterchain/> framework works and implement
> the functionalitiy
> of propertyfile
> as a filter. Then it should be possible to change
> the implementation of
> propertyfile to make it use filters.
> To my opinion, all tasks which we have which are
> manipulating text files
> should be rewritten around filters. This would avoid
> code duplication.
> And make the functionality of property file
> available on the fly.
> 
> Cheers,
> 
> Antoine
> 
> Phil Hourihane wrote:
> 
> >Hi folks,
> >
> >I hope I am getting the etiquette right for this; I
> am
> >a new body on the list.
> >
> >The PropertyFile (optional) task allows a script to
> >alter an existing properties file, but all comments
> >and layout are lost. This doesn't get a mention in
> >bugzilla. I have an enhancement which retains
> layout
> >and comments when writing a properties file, with
> >accompanying tests.
> >
> >I have a patch for the affected files, and there
> are a
> >few new files (util class, test class, and test
> data)
> >as well.
> >
> >Do the group want the enhancement? Or more detail
> from
> >me? Shall I post the patch and new files? Any
> feedback
> >is welcome.
> >
> >Philip Hourihane
> >
> >
> >	
> >	
> >		
> >  
> >
> 
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 
> 
>
**************************************************************
> This message, including any attachments, contains
> confidential information intended for a specific
> individual and purpose, and is protected by law.  If
> you are not the intended recipient, please contact
> sender immediately by reply e-mail and destroy all
> copies.  You are hereby notified that any
> disclosure, copying, or distribution of this
> message, or the taking of any action based on it, is
> strictly prohibited.
> TIAA-CREF
>
**************************************************************
> 
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 


___________________________________________________________ 
Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org