ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: svn commit: r292420 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Expand.java
Date Fri, 30 Sep 2005 14:31:54 GMT
--- Stefan Bodewig <bodewig@apache.org> wrote:

> On Thu, 29 Sep 2005, Matt Benson
> <gudnabrsam@yahoo.com> wrote:
> > --- bodewig@apache.org wrote:
> > [SNIP]
> >> Log:
> >> empty collection != no collection - found by Gump
> >> and the jline build
> > 
> > IIRC I had handled similar issues by lazily
> > initializing the internal RC (here Union) and
> testing
> > for null.  :)
> 
> Yes, I understand that now.
> 
> And I understand why you could live with using
> Resources - it throws
> an exception on size() if it doesn't contain any
> resource collections.
> That's one of the main reasons that made me switch
> to Union.

Doesn't matter, we can make empty <resources> valid if
we want to.

> 
> I guess I have to revisit all my changes and switch
> to lazy
> initialization as well.

If what you've already done works, I don't necessarily
see a need to change it.  I just mentioned it.  :)

-Matt
> 
> Stefan
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 



		
__________________________________ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message