ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <Jan.Mate...@rzf.fin-nrw.de>
Subject AW: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs MakeUrlTest.java
Date Tue, 23 Aug 2005 05:43:12 GMT
>  Index: MakeUrl.java
>  =================================================================== 
> ...
>   * @ant.task category="core" name="tourl"

s/tourl/makeurl/   you are using that in the default.properties (not the SmartFrog name :-)



      /**
       * error message
       */
      public static final String ERROR_MISSING_FILE = "A source file is missing :";
      public static final String ERROR_NO_PROPERTY = "No property defined";
      public static final String ERROR_NO_FILES = "No files defined";

A JavaDoc comment only for the first? No {@value} ?  <g>



      private String filesetsToURL() {
      ...
                  log(asUrl, Project.MSG_DEBUG);


Would the output of the origin file be helpful?

                  log(f + " --> " + asUrl, Project.MSG_DEBUG);


Mmh - same log statement in pathsToURL() ...




      public void execute() throws BuildException {
          validate();
          //now exit here if the property is already set
          if (getProject().getProperty(property) != null) {
              return;
          }

A log statement would be helpful

          if (getProject().getProperty(property) != null) {
              log("property '" + property + "' already set, exiting <makeurl>", Project.MSG_VERBOSE);
 
                //same log level as setting the property
              return;
          }

cheers
Jan


>-----Urspr√ľngliche Nachricht-----
>Von: Stefan Bodewig [mailto:bodewig@apache.org] 
>Gesendet: Dienstag, 23. August 2005 06:06
>An: dev@ant.apache.org
>Betreff: Re: cvs commit: 
>ant/src/testcases/org/apache/tools/ant/taskdefs MakeUrlTest.java
>
>On 22 Aug 2005, <stevel@apache.org> wrote:
>
>>               url = fileToConvert.toURI().toURL().toExternalForm();
>
>I think File.toURI is JDK 1.4+.
>
>What is wrong with FileUtils.toURL()?  Shouldn't we improve 
>FileUtils and use that from the task if anything is wrong?
>
>Stefan
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For 
>additional commands, e-mail: dev-help@ant.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message