ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Loughran <ste...@apache.org>
Subject Re: [PATCH] Execute.java patch for OpenVMS
Date Wed, 06 Jul 2005 12:28:03 GMT
Knut Wannheden wrote:
> Hi all!
> 
> A long time ago I submitted some patches to get Ant running on
> OpenVMS. There didn't seem to be much interest in this at the time,
> but I've now noticed that there actually seem to be people using it
> and requesting enhancements.
> 
> I here have a quite embarassing patch to my original patch to the
> Execute class. It was in fact embarassing enough that I haven't
> reported it up until now ;-) The problem is that the first environment
> variable won't get set (as a logical) as the loop starts looping with
> index 1 instead of 0...
> 
> Let me know if you'd prefer the patch as a file attachment or even a
> Bugzilla entry.
> 
> Cheers,
> 
> --knut
> 
> Index: Execute.java
> ===================================================================
> RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/Execute.java,v
> retrieving revision 1.95
> diff -u -r1.95 Execute.java
> --- Execute.java	12 Jun 2005 18:04:16 -0000	1.95
> +++ Execute.java	6 Jul 2005 09:13:57 -0000
> @@ -1153,7 +1153,7 @@
>                  // add the environment as logicals to the DCL script
>                  if (env != null) {
>                      int eqIndex;
> -                    for (int i = 1; i < env.length; i++) {
> +                    for (int i = 0; i < env.length; i++) {
>                          eqIndex = env[i].indexOf('=');
>                          if (eqIndex != -1) {
>                              out.print("$ DEFINE/NOLOG ");
> 

that is a simple enough defect that we can patch in situ.

OK. done!.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message