Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 62380 invoked from network); 13 Jun 2005 16:06:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 13 Jun 2005 16:06:01 -0000 Received: (qmail 79618 invoked by uid 500); 13 Jun 2005 16:05:46 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 79520 invoked by uid 500); 13 Jun 2005 16:05:45 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 79466 invoked by uid 99); 13 Jun 2005 16:05:45 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from kruithof.xs4all.nl (HELO kruithof.xs4all.nl) (213.84.255.5) by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 13 Jun 2005 09:05:41 -0700 Received: from aldi.jkf ([192.168.2.4] helo=[127.0.0.1]) by kruithof.xs4all.nl with esmtp (Exim 4.43) id 1DhrRD-0006CM-03 for dev@ant.apache.org; Mon, 13 Jun 2005 18:05:23 +0200 Message-ID: <42ADAE74.7000108@kruithof.xs4all.nl> Date: Mon, 13 Jun 2005 18:04:04 +0200 From: Martijn Kruithof User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ant Developers List Subject: Re: cvs commit: ant/src/main/org/apache/tools/ant/helper ProjectHelper2.java References: <20050612175514.17490.qmail@minotaur.apache.org> In-Reply-To: <20050612175514.17490.qmail@minotaur.apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi During cleaning up last weekend I noticed something "funny", and hoped for a reaction. Here is the request distilled out of the entire commit message: jkf@apache.org wrote > > I think there is an error in ConCat, see added comment. > > > 1.46 +4 -1 ant/src/main/org/apache/tools/ant/taskdefs/Concat.java > > Index: Concat.java > =================================================================== > RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Concat.java,v > retrieving revision 1.45 > retrieving revision 1.46 > diff -u -r1.45 -r1.46 > --- Concat.java 12 Jun 2005 15:54:14 -0000 1.45 > +++ Concat.java 12 Jun 2005 17:55:14 -0000 1.46 > @@ -431,6 +431,10 @@ > if (!outofdate) { > for (Iterator i = existRc.iterator(); !outofdate && i.hasNext();) { > Resource r = (Resource) i.next(); > + //TODO jkf, Seems the following code, or code like the > + //following code is missing, can someone confirm? > + //outofdate = (r.getLastModified()==0L || > + // r.getLastModified() > destinationFile.lastModified()) > } > } > if (!outofdate) { > > Martijn --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org