Return-Path: 
 <dev-return-66776-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 24333 invoked from network); 13 May 2005 13:28:42 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 13 May 2005 13:28:42 -0000
Received: (qmail 87262 invoked by uid 500); 13 May 2005 13:32:57 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 87193 invoked by uid 500); 13 May 2005 13:32:56 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 87164 invoked by uid 99); 13 May 2005 13:32:55 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Received: from Unknown (HELO cellectivity.com) (212.18.242.163)
  by apache.org (qpsmtpd/0.28) with ESMTP; Fri, 13 May 2005 06:32:55 -0700
Content-class: urn:content-classes:message
Subject: RE: [Bug 28444]  - Import: Target Handling Bug
MIME-Version: 1.0
Date: Fri, 13 May 2005 14:29:36 +0100
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Message-ID: <EA9D95F907E2924A9A32F274114BCDEF0D4681@perth.Cellectivity.local>
X-MS-Has-Attach: 
X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0
X-MS-TNEF-Correlator: 
Thread-Topic: [Bug 28444]  - Import: Target Handling Bug
thread-index: AcVXKdDbWhJKCSpVQpaNL8w0LlYgmgAkyoNA
From: "Jose Alberto Fernandez" <jalberto@cellectivity.com>
To: "Ant Developers List" <dev@ant.apache.org>
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N


Just to put closure in my list of peeves about <import>,
I really think we need a way to define "private" targets.

Now, for this to work properly, you need:

1) A way to mark a target as private.
2) private targets must be ignored by targets of the same names on other

points in the hierarchy.
3) Depends on a private target must be resolved by the correct instance
of the target.

So lets assume the following syntax:

 <private-target name=3D"..." depends=3D"....">...</private-target>

foo.xml
<project name=3D"foo1">
  <target name=3D"compile" depends=3D"setup"><echo
message=3D"compiling"/></target>
</project>

bar.xml
<project name=3D"bar1">
  <import file=3D"foo.xml" as=3D"f"/>
  <target name=3D"build" depends=3D"setup"><echo
message=3D"building"/></target>
  <private-target name=3D"setup"><echo message=3D"prepare
build"/></private-target>
</project>

baz.xml
<project name=3D"baz1">
  <import file=3D"bar.xml" as=3D"b"/>
  <target name=3D"setup"><echo message=3D"prepare compile"/>
</project>

ant compile
  prepare compile
  compiling

ant build
  prepare build
  building

Here:=20
foo.xml is like an abstract project which does not define "setup";
bar.xml's setup is private to bar1 and will not be used by the
dependency in foo1
baz.xml overrides (defines in this case) the setup target used in foo1
but not the one in bar1.

The rewriting rules are a bit tricky, because for every private target
you need to use a new "private name" for it, and change all the
occurencies
in dependencies on that file of the name, for the new name.

Seems actually doable.

Jose Alberto



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org