Return-Path: 
 <dev-return-67297-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 35942 invoked from network); 27 May 2005 08:35:18 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 27 May 2005 08:35:18 -0000
Received: (qmail 31614 invoked by uid 500); 27 May 2005 08:35:16 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 31553 invoked by uid 500); 27 May 2005 08:35:15 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 31540 invoked by uid 99); 27 May 2005 08:35:15 -0000
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: domain of antoine@gmx.de designates
 213.165.64.20 as permitted sender)
Received: from pop.gmx.net (HELO mail.gmx.net) (213.165.64.20)
  by apache.org (qpsmtpd/0.28) with SMTP; Fri, 27 May 2005 01:35:14 -0700
Received: (qmail invoked by alias); 27 May 2005 08:35:02 -0000
Received: from p54B11EC1.dip0.t-ipconnect.de (EHLO [127.0.0.1])
 [84.177.30.193]
  by mail.gmx.net (mp014) with SMTP; 27 May 2005 10:35:02 +0200
X-Authenticated: #22961642
Message-ID: <4296DBAD.5070104@gmx.de>
Date: Fri, 27 May 2005 10:34:53 +0200
From: Antoine Levy-Lambert <antoine@gmx.de>
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ant Developers List <dev@ant.apache.org>
Subject: Re: cvs commit: ant/src/etc/testcases/taskdefs/optional/net ftp.xml
References: <20050522184842.59453.qmail@minotaur.apache.org>
 <4291618F.6090505@gmx.de> <429516CB.8070302@javactivity.org>
 <4295263B.4020103@javactivity.org>
In-Reply-To: <4295263B.4020103@javactivity.org>
X-Enigmail-Version: 0.90.0.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Steve Cohen wrote:

> Antoine:  OK, I've taken a look.  Here is the problem, or maybe I 
> don't understand EnumeratedAttribute fully.
>
> In response to a suggestion of Steve Loughran the other day, I've 
> implemented all of my new attributes with the convention that a value 
> of "" means "Don't set the attribute - leave the default value in 
> place". This was to accomodate Steve's suggestion of wanting 
> property-file driven scripts.
>
> Such a script would define
> <property name="timestampGranularity" value=""/>
> An optional property file could define
>
> timestampGranularity=MINUTE
>
> or
>
> timestampGranularity=NONE.
>
> If neither specified, the default to be used (whose value varies 
> depending on the chosen action).
>
> I'm having difficulty understanding how this convention would fit into 
> the pattern of EnumeratedAttribute.  There may be such a way that I'm 
> just not understanding.  I'm still open to whatever suggestions you 
> might have on this score or alternative ideas to improve this code.
>
Hello Steve,

in this case, you can say that "" == TIMESTAMPGRANULARITY_DEFAULT
and document that DEFAULT is different depending upon the action put or 
get ?


Cheers,

Antoine


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org