Return-Path: 
 <dev-return-66396-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 60825 invoked from network); 3 May 2005 08:48:41 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 3 May 2005 08:48:41 -0000
Received: (qmail 88462 invoked by uid 500); 3 May 2005 08:50:14 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 88418 invoked by uid 500); 3 May 2005 08:50:14 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 88384 invoked by uid 99); 3 May 2005 08:50:13 -0000
X-ASF-Spam-Status: No, hits=0.1 required=10.0
	tests=FORGED_RCVD_HELO
X-Spam-Check-By: apache.org
Received-SPF: neutral (hermes.apache.org: local policy)
Received: from gate.corvil.net (HELO corvil.com) (213.94.219.177)
  by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 03 May 2005 01:50:12 -0700
Received: from [172.18.1.171] (angel.local.corvil.com [172.18.1.171])
	by corvil.com (8.13.3/8.13.3) with ESMTP id j438mSOm076957
	for <dev@ant.apache.org>; Tue, 3 May 2005 09:48:28 +0100 (IST)
	(envelope-from peterreilly@apache.org)
Message-ID: <42773AE7.4060209@apache.org>
Date: Tue, 03 May 2005 09:48:39 +0100
From: Peter Reilly <peterreilly@apache.org>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ant Developers List <dev@ant.apache.org>
Subject: Re: AW: AW: cvs commit: ant/src/main/org/apache/tools/ant DemuxOutput
 Stre am.java
References: <879A5AD5DD0ED511891F0003473A9B5614F6067E@Z011004>
In-Reply-To: <879A5AD5DD0ED511891F0003473A9B5614F6067E@Z011004>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Jan.Materne@rzf.fin-nrw.de wrote:

>>>Mmh checkstyle-config [1] sais 
>>>    <module name="LineLength">
>>>      <property name="max" value="100"/>
>>>      <property name="ignorePattern" value="^ *\* *[^ ]+$"/>
>>>    </module>
>>>sounds like java-length-max is 100, javadoc-length-max isnt set.
>>>
>>>      
>>>
>>I think I set that originally. I probably chose that as a more 
>>achievable goal to start with.
>>    
>>
>
>
>I think the Sun guidelines use 80.
>But should we change? How many sources have lines>80?
>  
>
We should try to make the code complient with the current rules
before making the rules more restrictive. 100 characters is fine, it
catches the silly 1000 character lines.

Peter

>Jan
>
>  
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org