Return-Path: 
 <dev-return-66834-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 62215 invoked from network); 17 May 2005 10:48:48 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 17 May 2005 10:48:48 -0000
Received: (qmail 41891 invoked by uid 500); 17 May 2005 00:13:14 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 41832 invoked by uid 500); 17 May 2005 00:13:13 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 41765 invoked by uid 99); 17 May 2005 00:13:07 -0000
X-ASF-Spam-Status: No, hits=0.2 required=10.0
	tests=NO_REAL_NAME
X-Spam-Check-By: apache.org
Received: from ajax-1.apache.org (HELO ajax.apache.org) (192.87.106.226)
  by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 16 May 2005 17:13:07 -0700
Received: by ajax.apache.org (Postfix, from userid 99)
	id 9D4962F3; Tue, 17 May 2005 02:12:12 +0200 (CEST)
From: bugzilla@apache.org
To: dev@ant.apache.org
Subject: DO NOT REPLY [Bug 34941]  New:  -
    FTP uptodate calculations wrong
X-Bugzilla-Reason: AssignedTo
Message-Id: <20050517001212.9D4962F3@ajax.apache.org>
Date: Tue, 17 May 2005 02:12:12 +0200 (CEST)
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34941>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34941

           Summary: FTP uptodate calculations wrong
           Product: Ant
           Version: unspecified
          Platform: All
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Optional Tasks
        AssignedTo: dev@ant.apache.org
        ReportedBy: scohen@apache.org


Given the following task call

<ftp action = "get" 
       ...
       preservelastmodified="true"
       newer="true">
   <fileset.../>
</ftp>

If this is executed a second time, all files included in the fileset will be
retrieved regardless of whether or not they have changed on the server in the
intervening time interval.

This is because the underlying uptodate logic is returning false if the source
and destination timestamps are equal.  Logically, it should be true.  Logically,
any file where the local file's timestamp is greater than or equal to the remote
file's timestamp is up to date.  Any file whose local timestamp is less than its
remote file's timestamp is not.  But that's not the current implementation.

A similar issue exists on put.

The fix is easy to implement and I will do it, but I want to give the community
a chance to comment before implementing.  There may be a use case for the
existing functionality that I am not understanding, or there may be an important
backward compatibility issue that I am missing.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org