Return-Path: 
 <dev-return-66028-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 99304 invoked from network); 19 Apr 2005 15:38:22 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 19 Apr 2005 15:38:22 -0000
Received: (qmail 60689 invoked by uid 500); 19 Apr 2005 15:38:20 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 60637 invoked by uid 500); 19 Apr 2005 15:38:19 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 60618 invoked by uid 99); 19 Apr 2005 15:38:19 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (hermes.apache.org: local policy)
Received: from bodewig.bost.de (HELO bodewig.bost.de) (62.96.16.111)
  by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 19 Apr 2005 08:38:18 -0700
Received: (from bodewig@localhost)
	by bodewig.bost.de (8.11.6/8.11.6) id j3JFcEx01537;
	Tue, 19 Apr 2005 17:38:14 +0200
X-Authentication-Warning: bodewig.bost.de: bodewig set sender to
 bodewig@apache.org using -f
To: dev@ant.apache.org
Subject: BuildException wrapping in <macrodef>
X-Draft-From: ("nnfolder:mail.jakarta-ant" "")
From: Stefan Bodewig <bodewig@apache.org>
Date: Tue, 19 Apr 2005 17:38:14 +0200
Message-ID: <m37jiy4w0p.fsf@bodewig.bost.de>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Security Through
 Obscurity, linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Hi,

using

<project xmlns:au="antlib:org.apache.ant.antlib.antunit">
  <au:assertEquals expected="bar" actual="baz"/>
</project>

I get

/tmp/au.xml:2: The following error occurred while executing this line:
jar:file:/home/bodewig/ASF/jakarta/ant/sandbox/antlibs/antunit/trunk/build/lib/ant-antunit.jar!/org/apache/ant/antlib/antunit/antlib.xml:40: Expected 'bar' but was 'baz'

what I really want is

/tmp/au.xml:2:  Expected 'bar' but was 'baz'

The reason for this is that assertEquals is a <macrodef> and
MacroInstance unconditionally wraps any BuildExecption into a new one
adding the macro definition's location.

For tasks provided in antlibs, the user probably doesn't care whether
it is a macrodef or a plain task.

Would anybody object if I added an attribute to macrodef that you
could use to turn off the wrapping (default would certainly be with
wrapping)?

Another side effect of this is that an ExitStatusException thrown by
<fail> nested into <macrodef> gets turned into a plain BuildException
again.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org