ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: Last-minute change to 1.6.3 :(
Date Thu, 07 Apr 2005 11:53:36 GMT

--- Antoine Levy-Lambert <antoine@gmx.de> wrote:
> Hello Matt,
> 
> Matt Benson wrote:
> 
> >>Hi all,
> >>
> >>There are some changes that need to be made to
> >>Executor functionality before the interface is
> >>released in 1.6.3 .  I was supposed to do this and
> >>forgot before the RC was made (see bug 22901). 
> I'd
> >>like to get Antoine's blessing to make the
> necessary
> >>changes to HEAD and the 1.6 branch.
> >>    
> >>
> >
> >  
> >
> I have had a look at this attachment.
>
http://issues.apache.org/bugzilla/attachment.cgi?id=13904
> referenced from
>
http://issues.apache.org/bugzilla/show_bug.cgi?id=22901
> I would like to hear the opinion of other
> committers. It sounds OK for me.

Also be aware that what I would be committing would
not be that exact patch, but fulfills the spirit. 
Alexey and I have coordinated on it.

> 
> >Also, given what's coming in Ant 1.7 with
> >ResourceCollections and set operations I would like
> to
> >modify the length task ever-so-slightly to NOT
> exclude
> >duplicate files.  Once again I apologize for
> >compromising the release schedule.
> >
> >  
> >
> Can you explain.

Okay... :)  when the current version of the length
task operates on one or more filesets, my thought was
that the length of a set of files is the length of its
union and so I discarded duplicates.  In the
ResourceCollection code there is explicit support for
unions so I have tried to make all implementations
keep duplicates with the exception of Union (and Path
for BC).  Since length is a new task this time, I
would rather not have to add ignoreDuplicates="false"
(kludge) to preserve BC when I know about the issue
already before length is ever released.  I hope this
clears things up a little.

-Matt

> 
> >-Matt
> >
> >  
> >
> Cheers,
> Antoine
> 
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 


		
__________________________________ 
Do you Yahoo!? 
Yahoo! Personals - Better first dates. More second dates. 
http://personals.yahoo.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message