Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 36166 invoked from network); 29 Mar 2005 18:41:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 29 Mar 2005 18:41:42 -0000 Received: (qmail 3009 invoked by uid 500); 29 Mar 2005 18:41:41 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 2975 invoked by uid 500); 29 Mar 2005 18:41:41 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 2961 invoked by uid 99); 29 Mar 2005 18:41:41 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of jak-ant-dev@m.gmane.org designates 80.91.229.2 as permitted sender) Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 29 Mar 2005 10:41:39 -0800 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1DGLcw-0006jz-LO for dev@ant.apache.org; Tue, 29 Mar 2005 20:39:46 +0200 Received: from c-24-61-15-229.hsd1.ma.comcast.net ([24.61.15.229]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Mar 2005 20:39:46 +0200 Received: from jesse.glick by c-24-61-15-229.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Mar 2005 20:39:46 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: dev@ant.apache.org From: Jesse Glick Subject: diff -b (was: Re: cvs commit: ant/src/etc/testcases/taskdefs input.xml) Date: Tue, 29 Mar 2005 13:39:50 -0500 Organization: Sun Microsystems / NetBeans Lines: 50 Message-ID: References: <20050329183546.33522.qmail@minotaur.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: c-24-61-15-229.hsd1.ma.comcast.net User-Agent: Mozilla Thunderbird 1.0.2-1.3.2 (X11/20050324) X-Accept-Language: en-us, en In-Reply-To: <20050329183546.33522.qmail@minotaur.apache.org> Sender: news X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N By the way, this kind of diff: jglick@apache.org wrote: > Removing old code testing for JDK 1.0 and 1.1. > > Index: SunJavah.java > =================================================================== > - // JDK1.1 is rather simpler than JDK1.2 > - if (JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_1)) { > - if (javah.getVerbose()) { > - cmd.createArgument().setValue("-v"); > - } > - } else { > - if (javah.getVerbose()) { > - cmd.createArgument().setValue("-verbose"); > - } > - if (javah.getOld()) { > - cmd.createArgument().setValue("-old"); > - } > - if (javah.getForce()) { > - cmd.createArgument().setValue("-force"); > - } > - if (javah.getStubs() && !javah.getOld()) { > - throw new BuildException("stubs only available in old mode.", > - javah.getLocation()); > - } > + if (javah.getVerbose()) { > + cmd.createArgument().setValue("-verbose"); > + } > + if (javah.getOld()) { > + cmd.createArgument().setValue("-old"); > + } > + if (javah.getForce()) { > + cmd.createArgument().setValue("-force"); > + } > + if (javah.getStubs() && !javah.getOld()) { > + throw new BuildException("stubs only available in old mode.", > + javah.getLocation()); > } ...is rather easier to read if you pass -b to cvs diff. In principle a semantically important change could be skipped over, but this seems to be rare in practice. Do we have any influence over the CVS commit mailer script? -J. -- jesse.glick@sun.com x22801 netbeans.org ant.apache.org if I had known it was harmless I would have killed it myself --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org