ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Hatcher <e...@ehatchersolutions.com>
Subject Re: FileSets with optional basedir and absolute paths for includes
Date Wed, 09 Mar 2005 03:38:47 GMT
I'm all for making File*Set* actually be capable of a true set of files 
anywhere I choose.  The basedir restriction is one of the single 
biggest walls I hit and workaround.  So, +1 from me.

	Erik

On Mar 8, 2005, at 6:45 PM, Matt Benson wrote:

> Time for controversy!  There is an interesting thread
> at
> http://issues.apache.org/bugzilla/show_bug.cgi?id=5035
> that touches on this issue.  The key issue was that
> some tasks (including 3rd party ones) would break if
> AFS.getDir() were to return null.  This is indeed
> true.  I have implemented the subject line, and the
> following tasks/types had to be touched:
>
> M src/main/org/apache/tools/ant/taskdefs/Copy.java
> (made copying abs. paths imply flattening)
>
> M src/main/org/apache/tools/ant/taskdefs/Delete.java
> (log message accessed dir)
>
> M
> src/main/org/apache/tools/ant/taskdefs/DependSet.java
> (depend stuff needs a basedir for package resolution)
>
> M src/main/org/apache/tools/ant/taskdefs/Javadoc.java
> (requires dir w/ packagesets b/c of package
> resolution)
>
> M src/main/org/apache/tools/ant/taskdefs/
>     optional/ide/VAJImport.java
> (easier to assume with untestables)
> M src/main/org/apache/tools/ant/taskdefs/
>     optional/metamata/AbstractMetamataTask.java
> (easier to assume with untestables)
> M src/main/org/apache/tools/ant/taskdefs/
>     optional/ssh/Scp.java
> (too complex to deal with yet)
> M src/main/org/apache/tools/ant/types/
>     optional/depend/ClassfileSet.java
> (depend stuff needs a basedir for package resolution)
>
>
> However, as I stated on the referenced bug entry, the
> API has never AFAICT promised that getDir would return
> a non-null result.  The overwhelming majority of tasks
> would be unaffected by this as many tasks would simply
> use the directory as the first parameter of new
> File(File, String).  No harm done.  This has been an
> outstanding request for a long time.  I feel that it
> represents little risk; fileset's documentation can be
> liberally sprinkled with warnings that errors might be
> encountered using dir-less filesets with some
> third-party tasks, and we can encourage third-party
> providers to make sure they are compatible.  If we
> scheduled this for 1.7 we could put ample warnings
> into 1.6.3 that this is coming.
>
> So what say you all?
>
> -Matt
>
>
> 	
> 		
> __________________________________
> Celebrate Yahoo!'s 10th Birthday!
> Yahoo! Netrospective: 100 Moments of the Web
> http://birthday.yahoo.com/netrospective/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message