ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse Glick <jesse.gl...@sun.com>
Subject diff -b (was: Re: cvs commit: ant/src/etc/testcases/taskdefs input.xml)
Date Tue, 29 Mar 2005 18:39:50 GMT
By the way, this kind of diff:

jglick@apache.org wrote:
>   Removing old code testing for JDK 1.0 and 1.1.
>   
>   Index: SunJavah.java
>   ===================================================================
>   -        // JDK1.1 is rather simpler than JDK1.2
>   -        if (JavaEnvUtils.isJavaVersion(JavaEnvUtils.JAVA_1_1)) {
>   -            if (javah.getVerbose()) {
>   -                cmd.createArgument().setValue("-v");
>   -            }
>   -        } else {
>   -            if (javah.getVerbose()) {
>   -                cmd.createArgument().setValue("-verbose");
>   -            }
>   -            if (javah.getOld()) {
>   -                cmd.createArgument().setValue("-old");
>   -            }
>   -            if (javah.getForce()) {
>   -                cmd.createArgument().setValue("-force");
>   -            }
>   -            if (javah.getStubs() && !javah.getOld()) {
>   -                throw new BuildException("stubs only available in old mode.", 
>   -                                         javah.getLocation());
>   -            }
>   +        if (javah.getVerbose()) {
>   +            cmd.createArgument().setValue("-verbose");
>   +        }
>   +        if (javah.getOld()) {
>   +            cmd.createArgument().setValue("-old");
>   +        }
>   +        if (javah.getForce()) {
>   +            cmd.createArgument().setValue("-force");
>   +        }
>   +        if (javah.getStubs() && !javah.getOld()) {
>   +            throw new BuildException("stubs only available in old mode.", 
>   +                                     javah.getLocation());
>            }

...is rather easier to read if you pass -b to cvs diff. In principle a 
semantically important change could be skipped over, but this seems to 
be rare in practice. Do we have any influence over the CVS commit mailer 
script?

-J.

-- 
jesse.glick@sun.com   x22801   netbeans.org   ant.apache.org
if I had known it was harmless I would have killed it myself


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message