ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Reilly <peterrei...@apache.org>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs SignJar.java
Date Wed, 23 Mar 2005 10:19:58 GMT
Steve Loughran wrote:

> Peter Reilly wrote:
>
>> stevel@apache.org wrote:
>>
>>> stevel      2005/03/22 09:20:06
>>>
>>>
>>>  +    public static final String WARN_JAR_AND_FILESET = "nested 
>>> filesets will be ignored if the jar attribute has"
>>>  +            + " been specified.";
>>>  +    public static final String ERROR_BAD_MAP = "Cannot map source 
>>> file to anything sensible: ";
>>>  +    public static final String ERROR_MAPPER_WITHOUT_DEST = "The 
>>> destDir attribute is required if a mapper is set";
>>>  +    public static final String ERROR_NO_SOURCE = "jar must be set 
>>> through jar attribute "
>>>  +            + "or nested filesets";
>>>  +    public static final String ERROR_NO_ALIAS = "alias attribute 
>>> must be set";
>>>  +    public static final String ERROR_NO_STOREPASS = "storepass 
>>> attribute must be set";
>>>  
>>>  
>>>
>> Is there a need for these to be public rather than private?
>> Peter
>
>
> could make them package scoped. I want to grab them in the unit tests.

Ah, that makes sense.
The reason I asked was because checkstyle whines about all the undocumented
public strings.

Peter


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message