ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Loughran <ste...@apache.org>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs SignJar.java
Date Wed, 23 Mar 2005 10:05:55 GMT
Peter Reilly wrote:
> stevel@apache.org wrote:
> 
>> stevel      2005/03/22 09:20:06
>>
>>  Modified:    src/main/org/apache/tools/ant/taskdefs SignJar.java
>>  Log:
>>  This is an interim checkin, with new features and some refactoring. 
>> All existing (minimal) tests should work, let's see what gump thinks.
>>  This is still a work in progress...
>>  
>>  Revision  Changes    Path
>>  1.47      +257 -95   
>> ant/src/main/org/apache/tools/ant/taskdefs/SignJar.java
>>  
>>  Index: SignJar.java
>>  ===================================================================
>>  RCS file: 
>> /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/SignJar.java,v
>>  retrieving revision 1.46
>>  retrieving revision 1.47
>>  diff -u -r1.46 -r1.47
>>  --- SignJar.java    18 Feb 2005 23:27:59 -0000    1.46
>>  +++ SignJar.java    22 Mar 2005 17:20:06 -0000    1.47
>>  @@ -1,24 +1,25 @@
>>   /*
>>  - * Copyright  2000-2005 The Apache Software Foundation
>>  - *
>> .
>>
> .
> .
> 
>>  +    public static final String ERROR_SIGNEDJAR_AND_FILESET =
>>  +            "The signedjar attribute is not supported with filesets";
>>  +    public static final String ERROR_TODIR_AND_SIGNEDJAR
>>  +            = "'destdir' and 'signedjar' cannot both be set";
>>  +    public static final String ERROR_TOO_MANY_MAPPERS = "Too many 
>> mappers";
>>  +    public static final String ERROR_SIGNEDJAR_AND_FILESETS = "You 
>> cannot specify the signed JAR when using filesets";
>>  +    public static final String WARN_JAR_AND_FILESET = "nested 
>> filesets will be ignored if the jar attribute has"
>>  +            + " been specified.";
>>  +    public static final String ERROR_BAD_MAP = "Cannot map source 
>> file to anything sensible: ";
>>  +    public static final String ERROR_MAPPER_WITHOUT_DEST = "The 
>> destDir attribute is required if a mapper is set";
>>  +    public static final String ERROR_NO_SOURCE = "jar must be set 
>> through jar attribute "
>>  +            + "or nested filesets";
>>  +    public static final String ERROR_NO_ALIAS = "alias attribute 
>> must be set";
>>  +    public static final String ERROR_NO_STOREPASS = "storepass 
>> attribute must be set";
>>  
>>  
>>
> Is there a need for these to be public rather than private?
> Peter

could make them package scoped. I want to grab them in the unit tests.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message