ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 24798] - BZip2: faster, less memory
Date Thu, 24 Mar 2005 08:48:30 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=24798>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24798





------- Additional Comments From bodewig@apache.org  2005-03-24 09:48 -------
Unfortunately I have a couple of problems with this patch.

First and most important, if I make them apply, the Ant tasks no longer work.

(1) The patch to Input makes <bunzip> fail because the class now expects the
stream to start with the BZip magic BZ - which the old didn't.  The tasks strips
the first two bytes from the stream and so the task now fails.  I certainly
could change the task as well, but there may be other clients that rely on the
old code.  This will lead me to problem number (3) below.

(2) The patch to Output causes an ArrayIndexOOBException in write0 when I run
<bzip2> - I haven't investigated further.

(3) is the time I had to spend on making the patch apply.  You've changed the
published API of the classes, which we can't do.  In particular we can't turn
BZip2Constants into a class, rename the constants of that interface or turn
protected methods/attributes into private ones.

In addition the diff is much larger than needed since you moved methods around,
changed the indentation and removed braces from one-line blocks.

I don't know whether you are still interested in getting this into Ant, given
that your patch is almost eighteen months old.  Part of the reason that I haven't
touched this earlier was (3) above since it looked like way to much work to
get the patch applied (and it took me sevaral hours yesterday, I should have
run my tests before I changed the coding style to Ant's).

I should have said so sooner and I'm sorry about this.

If you are no longer interested, then let us close this bug and keep in mind
that our BZip2 streams are probably slower than they could be.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message