Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 18612 invoked from network); 24 Jan 2005 15:38:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 24 Jan 2005 15:38:41 -0000 Received: (qmail 22312 invoked by uid 500); 24 Jan 2005 15:38:38 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 22241 invoked by uid 500); 24 Jan 2005 15:38:37 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 22215 invoked by uid 99); 24 Jan 2005 15:38:37 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=FORGED_RCVD_HELO X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from gate.corvil.net (HELO corvil.com) (213.94.219.177) by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 24 Jan 2005 07:38:36 -0800 Received: from [172.18.1.171] (angel.local.corvil.com [172.18.1.171]) by corvil.com (8.12.9/8.12.5) with ESMTP id j0OFcWwS045194 for ; Mon, 24 Jan 2005 15:38:32 GMT (envelope-from peterreilly@apache.org) Message-ID: <41F516E7.1060209@apache.org> Date: Mon, 24 Jan 2005 15:40:23 +0000 From: Peter Reilly User-Agent: Mozilla Thunderbird 0.9 (X11/20041103) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ant Developers List Subject: Re: cvs commit: ant/src/main/org/apache/tools/ant/util OutputStreamFunneler.java References: <20050124153210.70509.qmail@web30901.mail.mud.yahoo.com> In-Reply-To: <20050124153210.70509.qmail@web30901.mail.mud.yahoo.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Matt Benson wrote: >--- peterreilly@apache.org wrote: > > > >>peterreilly 2005/01/24 07:30:32 >> >> Modified: src/main/org/apache/tools/ant/util >>OutputStreamFunneler.java >> >> >[SNIP] > > >> >> - private class Funnel extends OutputStream { >> + private final class Funnel extends >>OutputStream { >> >> > >Just curious, why bother making a private inner class >final? > > To stop checkstyle from whining! The construtor was private and in this case checkstyle whines that the class should be final as it cannot be extended. Peter >-Matt > > > >__________________________________ >Do you Yahoo!? >Yahoo! Mail - Find what you need with new enhanced search. >http://info.mail.yahoo.com/mail_250 > >--------------------------------------------------------------------- >To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org >For additional commands, e-mail: dev-help@ant.apache.org > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org