Return-Path: Delivered-To: apmail-ant-dev-archive@www.apache.org Received: (qmail 41016 invoked from network); 11 Jan 2005 18:15:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 11 Jan 2005 18:15:08 -0000 Received: (qmail 70692 invoked by uid 500); 11 Jan 2005 18:15:06 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 70648 invoked by uid 500); 11 Jan 2005 18:15:06 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 70617 invoked by uid 99); 11 Jan 2005 18:15:05 -0000 X-ASF-Spam-Status: No, hits=2.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,FORGED_YAHOO_RCVD X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from web30908.mail.mud.yahoo.com (HELO web30908.mail.mud.yahoo.com) (68.142.200.161) by apache.org (qpsmtpd/0.28) with SMTP; Tue, 11 Jan 2005 10:15:04 -0800 Received: (qmail 40863 invoked by uid 60001); 11 Jan 2005 18:15:02 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; b=NvhJ3eVhUQELDO7nkA/UM0RqD1/gUT+6cf7LznWAesapgSXNe8raDyEqXCWk1/ThxesMQ99sHOR5cdSfW/PazoL1HdSCoOGcqrm9X3ZwmRED6wShhpIJ0dDPQ3gWAmPYH9UDjasf43gY/wXUVpfHX7Jhrqj/vQ69OSZn6nRpaxo= ; Message-ID: <20050111181502.40861.qmail@web30908.mail.mud.yahoo.com> Received: from [65.247.233.252] by web30908.mail.mud.yahoo.com via HTTP; Tue, 11 Jan 2005 10:15:02 PST Date: Tue, 11 Jan 2005 10:15:02 -0800 (PST) From: Matt Benson Subject: Re: or file collections To: Ant Developers List In-Reply-To: <41E4147F.6010800@apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N --- Peter Reilly wrote: [SNIP] > I just noticed the interface idea. I do not really > understand this, Clone > will still extend UE yes?. > > The Clone implementation is really clever, I am just > concerned that > there may be issues as it does extend UE. There are > a number > of places in the code that check if objects are > instance of UE - > Project.java, PresetDef.java and others and > implement different code if > the object is an instance of UE. To go back to the code, I mainly inherited from UE as a "spirit" thing and b/c makeObject was there and generic. So the interface suggestion was to make UE implement some e.g. ProxyElement interface that declares makeObject(), have Clone implement the same interface and method, then change the "if UE" block in UE.makeObject() to "if ProxyElement". I feel a little weird about making existing methods satisfy the contract of new interfaces, but I don't think it breaks anything. -Matt > > Peter __________________________________ Do you Yahoo!? Yahoo! Mail - now with 250MB free storage. Learn more. http://info.mail.yahoo.com/mail_250 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org