ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Reilly <peterrei...@apache.org>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Checksum.java
Date Thu, 06 Jan 2005 11:38:41 GMT
Most of these are setX(x) where x is already defined in the javadoc.
So there is no point in repeating the definition. (see the javadoc for
most of the jdk).

The buildexception statement is a bit meaningless, but it does capture
what will happen.

Peter

Martijn Kruithof wrote:

> I understand the importance of improving the style, but shouldn't we 
> prefer no comments (warnings stay to indicate they are missing)
> over this kind of comments:
> Kind Regards, Martijn
>
>>  +     * @param file a <code>File</code> value
>>  +     * @param algorithm a <code>String</code> value
>>  +     * @param provider a <code>String</code> value
>>  +     * @param fileext a <code>String</code> value
>>  +     * @param property a <code>String</code> value
>>  +     * @param totalproperty a <code>String</code> value
>>  +     * @param verifyProperty a <code>String</code> value
>>  +     * @param forceOverwrite a <code>boolean</code> value
>>  +     * @param size an <code>int</code> value
>>  +     * @param e an <code>enumerated</code> value
>>  +     * @param p a <code>String</code> value
>>  +     * @throws BuildException on error
>>  +     * @throws BuildException on error
>>  +         * @return a <code>MessageFormat</code> object.
>>  +         * @return an array of values.
>>  
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message