ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@yahoo.com>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant ComponentHelper.java
Date Fri, 28 Jan 2005 15:22:40 GMT
--- Peter Reilly <peterreilly@apache.org> wrote:

> Do we really need code that has to be read five
> times
> to figure out what it does?
> 

You cut me deep, Peter.  Would you settle for a
comment?  ;)

-Matt

> Peter
> 
> mbenson@apache.org wrote:
> 
> >mbenson     2005/01/27 13:53:27
> >
> >  Modified:    src/main/org/apache/tools/ant
> ComponentHelper.java
> >  Log:
> >  -2 characters
> >  
> >  Revision  Changes    Path
> >  1.47      +1 -1     
>
ant/src/main/org/apache/tools/ant/ComponentHelper.java
> >  
> >  Index: ComponentHelper.java
> > 
>
===================================================================
> >  RCS file:
>
/home/cvs/ant/src/main/org/apache/tools/ant/ComponentHelper.java,v
> >  retrieving revision 1.46
> >  retrieving revision 1.47
> >  diff -u -r1.46 -r1.47
> >  --- ComponentHelper.java	26 Jan 2005 20:12:51
> -0000	1.46
> >  +++ ComponentHelper.java	27 Jan 2005 21:53:27
> -0000	1.47
> >  @@ -583,7 +583,7 @@
> >       private boolean sameDefinition(
> >           AntTypeDefinition def, AntTypeDefinition
> old) {
> >           boolean defValid = validDefinition(def);
> >  -        boolean sameValidity = !(defValid ^
> validDefinition(old));
> >  +        boolean sameValidity = defValid ^
> !validDefinition(old);
> >           return sameValidity && (!defValid ||
> def.sameDefinition(old, project));
> >       }
> >   
> >  
> >  
> >  
> >
>
>---------------------------------------------------------------------
> >To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> >For additional commands, e-mail:
> dev-help@ant.apache.org
> >
> >
> >
> >  
> >
> 
> 
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@ant.apache.org
> For additional commands, e-mail:
> dev-help@ant.apache.org
> 
> 



		
__________________________________ 
Do you Yahoo!? 
Meet the all-new My Yahoo! - Try it today! 
http://my.yahoo.com 
 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message