Return-Path: 
 <dev-return-62530-apmail-ant-dev-archive=ant.apache.org@ant.apache.org>
Delivered-To: apmail-ant-dev-archive@www.apache.org
Received: (qmail 81441 invoked from network); 22 Dec 2004 22:27:06 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 22 Dec 2004 22:27:06 -0000
Received: (qmail 74929 invoked by uid 500); 22 Dec 2004 22:27:04 -0000
Delivered-To: apmail-ant-dev-archive@ant.apache.org
Received: (qmail 74880 invoked by uid 500); 22 Dec 2004 22:27:03 -0000
Mailing-List: contact dev-help@ant.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@ant.apache.org>
List-Subscribe: <mailto:dev-subscribe@ant.apache.org>
List-Help: <mailto:dev-help@ant.apache.org>
List-Post: <mailto:dev@ant.apache.org>
List-Id: "Ant Developers List" <dev.ant.apache.org>
Reply-To: "Ant Developers List" <dev@ant.apache.org>
Delivered-To: mailing list dev@ant.apache.org
Received: (qmail 74855 invoked by uid 99); 22 Dec 2004 22:27:03 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Received: from kruithof.xs4all.nl (HELO kruithof.xs4all.nl) (213.84.255.5)
  by apache.org (qpsmtpd/0.28) with ESMTP; Wed, 22 Dec 2004 14:27:00 -0800
Received: from aldi.jkf ([192.168.2.4])
	by kruithof.xs4all.nl with esmtp (Exim 4.42)
	id 1ChEwb-0008QG-70
	for dev@ant.apache.org; Wed, 22 Dec 2004 23:26:57 +0100
Message-ID: <41C9F493.3030708@kruithof.xs4all.nl>
Date: Wed, 22 Dec 2004 23:26:27 +0100
From: Martijn Kruithof <jm@kruithof.xs4all.nl>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.7.3) Gecko/20040910
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ant Developers List <dev@ant.apache.org>
Subject: Re: cvs commit:
 ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend
 DependTest.java
References: <20041222140823.87638.qmail@minotaur.apache.org>
In-Reply-To: <20041222140823.87638.qmail@minotaur.apache.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

Hi,

this test case would now also pass if no class has been found at all, is 
that intentional?

Kind Regards, Martijn

conor@apache.org wrote:

>conor       2004/12/22 06:08:23
>
>  Modified:    src/testcases/org/apache/tools/ant/taskdefs/optional/depend
>                        DependTest.java
>  Log:
>  JDM 1.5 compiler is much smarter than previous versions in the handling of
>  class references which should improve the performance of <depend>
>  
>  The test has been changed to work with either, allowing eitehr one or two files
>  PR:	32557
>  
>  Revision  Changes    Path
>  1.16      +2 -2      ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend/DependTest.java
>  
>  Index: DependTest.java
>  ===================================================================
>  RCS file: /home/cvs/ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend/DependTest.java,v
>  retrieving revision 1.15
>  retrieving revision 1.16
>  diff -u -w -u -r1.15 -r1.16
>  --- DependTest.java	16 Dec 2004 14:01:39 -0000	1.15
>  +++ DependTest.java	22 Dec 2004 14:08:23 -0000	1.16
>  @@ -71,8 +71,8 @@
>       public void testClosure() {
>           executeTarget("testclosure");
>           Hashtable files = getResultFiles();
>  -        assertEquals("Depend did not leave correct number of files", 2,
>  -            files.size());
>  +        assertTrue("Depend did not leave correct number of files", 
>  +            files.size() <= 2);
>           assertTrue("Result did not contain D.class",
>               files.containsKey("D.class"));
>       }
>  
>  
>  
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>For additional commands, e-mail: dev-help@ant.apache.org
>
>  
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org