ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: About <macrodef> in the trenches
Date Mon, 13 Dec 2004 14:56:34 GMT
On Fri, 10 Dec 2004, Peter Reilly <peterreilly@apache.org> wrote:

> 1) this attribute is good.
>      however, it is only really usefull in combination with the
>      iftrue attribute, or with ant-contrib "if" task

Agreed.  Or IOW, I don't think it is that useful without an if-task
like structure.

> 2) a default value for the element is good. The default value should
>     be in the declaration, but it is ok to have it the body of the
>     macrodef.

+1 for having it in the declaration.

> 3) this sounds good if a little stange initially.

Agreed on both counts (sounds useful and strange).

4) I don't like since I don't want to see the @{...} constructs leak
out of the <macrodef> body at all.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message